Bug 207530 - [LFC] Introduce Layout::InlineTextBox
Summary: [LFC] Introduce Layout::InlineTextBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-10 19:49 PST by zalan
Modified: 2020-02-11 07:13 PST (History)
11 users (show)

See Also:

Attachments
Patch (53.80 KB, patch)
2020-02-10 20:04 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (51.49 KB, patch)
2020-02-10 20:53 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (51.96 KB, patch)
2020-02-10 20:57 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (52.10 KB, patch)
2020-02-10 21:28 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-10 19:49:16 PST 
Layout::Box with Optional<text content> looks a bit odd.
Comment 1 Radar WebKit Bug Importer 2020-02-10 19:49:35 PST 
<rdar://problem/59336020>
Comment 2 zalan 2020-02-10 20:04:49 PST 
Created attachment 390340 [details]
Patch
Comment 3 Antti Koivisto 2020-02-10 20:19:56 PST 
Comment on attachment 390340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390340&action=review

> Source/WebCore/layout/layouttree/AnonymousInlineTextBox.h:37
> +class AnonymousInlineTextBox : public Box {

Shorter name would be cool as discussed.

> Source/WebCore/layout/layouttree/TextContext.h:-35
> -struct TextContext {

Another Context bites the dust!
Comment 4 zalan 2020-02-10 20:53:46 PST 
Created attachment 390342 [details]
Patch
Comment 5 zalan 2020-02-10 20:57:15 PST 
Created attachment 390343 [details]
Patch
Comment 6 zalan 2020-02-10 21:28:49 PST 
Created attachment 390344 [details]
Patch
Comment 7 WebKit Commit Bot 2020-02-11 06:53:23 PST 
The commit-queue encountered the following flaky tests while processing attachment 390344 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-02-11 06:53:47 PST 
The commit-queue encountered the following flaky tests while processing attachment 390344 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2020-02-11 07:13:20 PST 
Comment on attachment 390344 [details]
Patch

Clearing flags on attachment: 390344

Committed r256304: <https://trac.webkit.org/changeset/256304>
Comment 10 WebKit Commit Bot 2020-02-11 07:13:22 PST 
All reviewed patches have been landed.  Closing bug.