Bug 207502 – Rename VideoFullscreenLayerManager to VideoLayerManager

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

Rename VideoFullscreenLayerManager to VideoLayerManager

[Peng Liu]

Created attachment 390294 [details]
Patch

[Peng Liu]

Created attachment 390302 [details]
A clearer patch

[Peng Liu]

Comment on attachment 390302 [details]
A clearer patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846
> -		2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; };

Those are cleanup for https://trac.webkit.org/changeset/255241/webkit

[youenn fablet]

Comment on attachment 390302 [details]
A clearer patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review

>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846
>> -		2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; };
> 
> Those are cleanup for https://trac.webkit.org/changeset/255241/webkit

Could we try to not include these changes, or as separate unreviewed changes maybe. Ditto for below.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:328
> +    std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager;

We could use UniqueRef.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:245
> +    std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager;

Ditto here.

[Peng Liu]

Comment on attachment 390302 [details]
A clearer patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review

>>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846
>>> -		2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; };
>> 
>> Those are cleanup for https://trac.webkit.org/changeset/255241/webkit
> 
> Could we try to not include these changes, or as separate unreviewed changes maybe. Ditto for below.

Yes. It is done in webkit.org/b/207573.

>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:328
>> +    std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager;
> 
> We could use UniqueRef.

Right. Will do that in webkit.org/b/207592.

[Peng Liu]

Created attachment 390461 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 390461 [details]
patch for landing

Clearing flags on attachment: 390461

Committed r256424: <https://trac.webkit.org/changeset/256424>

[Radar WebKit Bug Importer]

<rdar://problem/59389344>