Bug 207502 - Rename VideoFullscreenLayerManager to VideoLayerManager
Summary: Rename VideoFullscreenLayerManager to VideoLayerManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on: 207573
Blocks: 206132
  Show dependency tree / graph
 
Reported: 2020-02-10 13:36 PST by Peng Liu
Modified: 2020-02-12 13:48 PST (History)
9 users (show)

See Also:

Attachments
Patch (70.36 KB, patch)
2020-02-10 14:07 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
A clearer patch (50.69 KB, patch)
2020-02-10 15:33 PST, Peng Liu 		youennf: review+
Details | Formatted Diff | Diff
patch for landing (42.40 KB, patch)
2020-02-11 16:34 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-02-10 13:36:15 PST 
Rename VideoFullscreenLayerManager to VideoLayerManager
Comment 1 Peng Liu 2020-02-10 14:07:43 PST 
Created attachment 390294 [details]
Patch
Comment 2 Peng Liu 2020-02-10 15:33:50 PST 
Created attachment 390302 [details]
A clearer patch
Comment 3 Peng Liu 2020-02-10 15:37:36 PST 
Comment on attachment 390302 [details]
A clearer patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846
> -		2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; };

Those are cleanup for https://trac.webkit.org/changeset/255241/webkit
Comment 4 youenn fablet 2020-02-11 05:29:57 PST 
Comment on attachment 390302 [details]
A clearer patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review

>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846
>> -		2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; };
> 
> Those are cleanup for https://trac.webkit.org/changeset/255241/webkit

Could we try to not include these changes, or as separate unreviewed changes maybe. Ditto for below.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:328
> +    std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager;

We could use UniqueRef.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:245
> +    std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager;

Ditto here.
Comment 5 Peng Liu 2020-02-11 15:42:55 PST 
Comment on attachment 390302 [details]
A clearer patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review

>>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846
>>> -		2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; };
>> 
>> Those are cleanup for https://trac.webkit.org/changeset/255241/webkit
> 
> Could we try to not include these changes, or as separate unreviewed changes maybe. Ditto for below.

Yes. It is done in webkit.org/b/207573.

>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:328
>> +    std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager;
> 
> We could use UniqueRef.

Right. Will do that in webkit.org/b/207592.
Comment 6 Peng Liu 2020-02-11 16:34:58 PST 
Created attachment 390461 [details]
patch for landing
Comment 7 WebKit Commit Bot 2020-02-11 21:11:26 PST 
Comment on attachment 390461 [details]
patch for landing

Clearing flags on attachment: 390461

Committed r256424: <https://trac.webkit.org/changeset/256424>
Comment 8 Radar WebKit Bug Importer 2020-02-12 09:32:26 PST 
<rdar://problem/59389344>