Bug 207498 - Adjust the minor version number for the desktop user agent string.
Summary: Adjust the minor version number for the desktop user agent string.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-10 13:16 PST by Keith Rollin
Modified: 2020-02-11 12:28 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2020-02-10 13:19 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-mojave (3.45 MB, application/zip)
2020-02-10 15:58 PST, WebKit Commit Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-02-10 13:16:50 PST 
Adjust the minor version number for the desktop user agent string.
Comment 1 Keith Rollin 2020-02-10 13:17:03 PST 
<rdar://problem/59274765>
Comment 2 Keith Rollin 2020-02-10 13:19:33 PST 
Created attachment 390286 [details]
Patch
Comment 3 Wenson Hsieh 2020-02-10 13:24:32 PST 
Comment on attachment 390286 [details]
Patch

I filed <https://bugs.webkit.org/show_bug.cgi?id=207500> to track making this a part of a build phase.
Comment 4 WebKit Commit Bot 2020-02-10 15:58:18 PST 
Comment on attachment 390286 [details]
Patch

Rejecting attachment 390286 [details] from commit-queue.

New failing tests:
editing/spelling/spellcheck-async-remove-frame.html
Full output: https://webkit-queues.webkit.org/results/13320451
Comment 5 WebKit Commit Bot 2020-02-10 15:58:20 PST 
Created attachment 390305 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mojave

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-mojave  Platform: Mac OS X 10.14.6
Comment 6 Keith Rollin 2020-02-10 16:14:41 PST 
Comment on attachment 390286 [details]
Patch

Ain't no way this change broke a Windows test.
Comment 7 Chris Dumez 2020-02-10 16:44:36 PST 
Comment on attachment 390286 [details]
Patch

Clearing flags on attachment: 390286

Committed r256230: <https://trac.webkit.org/changeset/256230>
Comment 8 Chris Dumez 2020-02-10 16:44:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Commit Bot 2020-02-10 16:51:56 PST 
The commit-queue encountered the following flaky tests while processing attachment 390286 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 10 Darin Adler 2020-02-11 12:28:26 PST 
Comment on attachment 390286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390286&action=review

> Source/WebCore/platform/ios/UserAgentIOS.mm:86
>          String appNameSuffix = applicationName.isEmpty() ? "" : makeString(" ", applicationName);
> -        return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15) AppleWebKit/605.1.15 (KHTML, like Gecko)", appNameSuffix);
> +        return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko)", appNameSuffix);

Not part of this patch, but for what it’s worth, here’s a more efficient idiom for cases like this:

    const char* separator = applicationName.isEmpty() ? "" : " ";
    return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko)", separator, applicationName);

Avoids creating and destroying a temporary WTF::String.