Bug 207484 – arm64_32: Mark microbenchmarks/delete-property-keeps-cacheable-structure.js is timing out on all Apple Watch models

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Justin Michaud]

arm64_32: microbenchmarks/delete-property-keeps-cacheable-structure.js is timing out

[Justin Michaud]

Created attachment 390268 [details]
Patch

[Justin Michaud]

rdar://59262882

[Yusuke Suzuki]

Comment on attachment 390268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390268&action=review

r=me

> JSTests/microbenchmarks/delete-property-keeps-cacheable-structure.js:1
> +//@ skip if $architecture == "arm64_32" or $architecture == "arm7k"

Should we use something like, `$model =~ /^Apple Watch/` etc.? But I don't have strong preference.

[Justin Michaud]

Created attachment 390272 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 390272 [details]
Patch

Clearing flags on attachment: 390272

Committed r256199: <https://trac.webkit.org/changeset/256199>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Re-titling, because this wasn't fixed, just the test skipped.

[Mark Lam]

(In reply to Alexey Proskuryakov from comment #7)
> Re-titling, because this wasn't fixed, just the test skipped.

[Mark Lam]

(In reply to Mark Lam from comment #8)
> (In reply to Alexey Proskuryakov from comment #7)
> > Re-titling, because this wasn't fixed, just the test skipped.

There's nothing more to fix here.  The test runs 5000000 iterations of its workload.  On Apple Watch which doesn't use the JIT, this is going to take forever, and will surely time out.  Skipping it is the right thing to do.