Bug 207482 - [iOS] Deny mach lookup access to analytics service in the WebContent process
Summary: [iOS] Deny mach lookup access to analytics service in the WebContent process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-10 10:55 PST by Per Arne Vollan
Modified: 2020-02-12 10:53 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.86 KB, patch)
2020-02-10 11:01 PST, Per Arne Vollan 		darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-02-10 10:55:39 PST 
As part of sandbox hardening work, this service should be denied in the WebContent process' sandbox.
Comment 1 Per Arne Vollan 2020-02-10 11:01:54 PST 
Created attachment 390267 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-02-10 11:02:22 PST 
<rdar://problem/59317479>
Comment 3 Per Arne Vollan 2020-02-12 07:13:17 PST 
Comment on attachment 390267 [details]
Patch

Thanks for reviewing!
Comment 4 Per Arne Vollan 2020-02-12 07:13:45 PST 
I think the win test failure is unrelated to this patch.
Comment 5 WebKit Commit Bot 2020-02-12 07:33:55 PST 
Comment on attachment 390267 [details]
Patch

Rejecting attachment 390267 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 390267, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=390267&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=207482&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 390267 from bug 207482.
Fetching: https://bugs.webkit.org/attachment.cgi?id=390267
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 5 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt
Hunk #1 FAILED at 17.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt.rej
patching file LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html
Hunk #1 FAILED at 20.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13321366
Comment 6 Per Arne Vollan 2020-02-12 10:53:30 PST 
Committed r256455: <https://trac.webkit.org/changeset/256455/webkit>