Bug 207473 - [WPE][GTK] Should install python3-secretstorage
Summary: [WPE][GTK] Should install python3-secretstorage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-10 09:40 PST by Michael Catanzaro
Modified: 2021-01-21 07:12 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.86 KB, patch)
2020-02-10 09:41 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-02-10 09:40:00 PST
If python3-secretstorage is not installed, webkit-patch will use a custom encrypted file for password storage instead of utilizing the system keyring. This means unnecessary password prompts to unlock the custom encrypted key storage.

There is no benefit to using custom key storage over the system keyring.
Comment 1 Michael Catanzaro 2020-02-10 09:41:13 PST
Created attachment 390257 [details]
Patch
Comment 2 Charlie Turner 2020-05-04 07:27:44 PDT
Not sure why this wasn't picked up, the current behaviour is irritating. informal r+ from me!
Comment 3 EWS 2020-05-04 08:58:58 PDT
Committed r261087: <https://trac.webkit.org/changeset/261087>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 390257 [details].