RESOLVED FIXED 207467
Support in-band VTT captions when loading media in the GPU Process 
https://bugs.webkit.org/show_bug.cgi?id=207467
Summary Support in-band VTT captions when loading media in the GPU Process
Eric Carlson
Reported 2020-02-10 09:12:36 PST
Support in-band VTT captions when loading media in the GPU Process
Attachments
Patch (121.19 KB, patch)
2020-02-10 10:42 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (123.75 KB, patch)
2020-02-10 11:16 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (124.15 KB, patch)
2020-02-10 11:23 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (123.38 KB, patch)
2020-02-11 06:04 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (124.27 KB, patch)
2020-02-11 08:38 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (127.52 KB, patch)
2020-02-11 10:17 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-10 09:12:46 PST
<rdar://problem/59312749>
Eric Carlson
Comment 2 2020-02-10 10:42:58 PST
Created attachment 390263 [details] Patch
Eric Carlson
Comment 3 2020-02-10 11:16:09 PST
Created attachment 390270 [details] Patch
Eric Carlson
Comment 4 2020-02-10 11:23:56 PST
Created attachment 390273 [details] Patch
Eric Carlson
Comment 5 2020-02-10 13:00:45 PST
The mac-wk1 test failures are happening because inspector/console/webcore-logging.html enabled verbose media logging and them timed out without disabling logging again, so every media test that ran afterwards has unexpected console logging.
Jer Noble
Comment 6 2020-02-10 13:19:02 PST
Comment on attachment 390273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390273&action=review > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:60 > + ## AddDataCue(MediaTime start, MediaTime end, IPC::DataReference data) > + ## AddDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data, String type) > + ## UpdateDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data) > + ## RemoveDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data) > + > + ## AddGenericCue(WebCore::GenericCueData cue) > + ## UpdateGenericCue(WebCore::GenericCueData cue) > + ## RemoveGenericCue(WebCore::GenericCueData cue) Are these supposed to be left in? > Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.messages.in:40 > + ## AddDataCue(MediaTime start, MediaTime end, IPC::DataReference data) > + ## AddDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data, String type) > + ## UpdateDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data) > + ## RemoveDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data) > + > + ## AddGenericCue(WebCore::GenericCueData cue) > + ## UpdateGenericCue(WebCore::GenericCueData cue) > + ## RemoveGenericCue(WebCore::GenericCueData cue) Ditto.
Eric Carlson
Comment 7 2020-02-11 06:04:52 PST
Created attachment 390356 [details] Patch
Eric Carlson
Comment 8 2020-02-11 08:38:54 PST
Created attachment 390371 [details] Patch for landing
Eric Carlson
Comment 9 2020-02-11 10:17:28 PST
Created attachment 390383 [details] Patch for landing
WebKit Commit Bot
Comment 10 2020-02-11 13:38:04 PST
Comment on attachment 390383 [details] Patch for landing Clearing flags on attachment: 390383 Committed r256353: <https://trac.webkit.org/changeset/256353>
WebKit Commit Bot
Comment 11 2020-02-11 13:38:07 PST
All reviewed patches have been landed. Closing bug.
Carlos Alberto Lopez Perez
Comment 12 2020-02-11 18:59:54 PST
Build fix for GTK/WPE Debug landed in https://trac.webkit.org/changeset/256421
Eric Carlson
Comment 13 2020-02-12 08:41:53 PST
(In reply to Carlos Alberto Lopez Perez from comment #12) > Build fix for GTK/WPE Debug landed in > https://trac.webkit.org/changeset/256421 Thanks for the fix Carlos, sorry I missed that!
Note You need to log in before you can comment on or make changes to this bug.