Support in-band VTT captions when loading media in the GPU Process
<rdar://problem/59312749>
Created attachment 390263 [details] Patch
Created attachment 390270 [details] Patch
Created attachment 390273 [details] Patch
The mac-wk1 test failures are happening because inspector/console/webcore-logging.html enabled verbose media logging and them timed out without disabling logging again, so every media test that ran afterwards has unexpected console logging.
Comment on attachment 390273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390273&action=review > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:60 > + ## AddDataCue(MediaTime start, MediaTime end, IPC::DataReference data) > + ## AddDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data, String type) > + ## UpdateDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data) > + ## RemoveDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data) > + > + ## AddGenericCue(WebCore::GenericCueData cue) > + ## UpdateGenericCue(WebCore::GenericCueData cue) > + ## RemoveGenericCue(WebCore::GenericCueData cue) Are these supposed to be left in? > Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.messages.in:40 > + ## AddDataCue(MediaTime start, MediaTime end, IPC::DataReference data) > + ## AddDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data, String type) > + ## UpdateDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data) > + ## RemoveDataCue(MediaTime start, MediaTime end, WebCore::SerializedPlatformRepresentation data) > + > + ## AddGenericCue(WebCore::GenericCueData cue) > + ## UpdateGenericCue(WebCore::GenericCueData cue) > + ## RemoveGenericCue(WebCore::GenericCueData cue) Ditto.
Created attachment 390356 [details] Patch
Created attachment 390371 [details] Patch for landing
Created attachment 390383 [details] Patch for landing
Comment on attachment 390383 [details] Patch for landing Clearing flags on attachment: 390383 Committed r256353: <https://trac.webkit.org/changeset/256353>
All reviewed patches have been landed. Closing bug.
Build fix for GTK/WPE Debug landed in https://trac.webkit.org/changeset/256421
(In reply to Carlos Alberto Lopez Perez from comment #12) > Build fix for GTK/WPE Debug landed in > https://trac.webkit.org/changeset/256421 Thanks for the fix Carlos, sorry I missed that!