Bug 207459 - [watchOS] Notification listener is never unregistered
Summary: [watchOS] Notification listener is never unregistered
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-10 07:16 PST by Per Arne Vollan
Modified: 2020-02-14 15:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2020-02-10 07:22 PST, Per Arne Vollan 		mjs: review+
Details | Formatted Diff | Diff
Patch (8.63 KB, patch)
2020-02-10 14:46 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-02-10 07:16:21 PST 
On watchOS, the backlight changed notification is registered in WebProcessPool::registerNotificationObservers(), but not unregistered in WebProcessPool::unregisterNotificationObservers().
Comment 1 Per Arne Vollan 2020-02-10 07:17:29 PST 
rdar://problem/58923393
Comment 2 Per Arne Vollan 2020-02-10 07:22:15 PST 
Created attachment 390250 [details]
Patch
Comment 3 Maciej Stachowiak 2020-02-10 11:14:22 PST 
Comment on attachment 390250 [details]
Patch

Maybe worth making an API test in case they are run there some day, or in case we make this mistake on another platform?

Code change looks fine but I suggest adding a test.
Comment 4 Per Arne Vollan 2020-02-10 12:51:11 PST 
(In reply to Maciej Stachowiak from comment #3)
> Comment on attachment 390250 [details]
> Patch
> 
> Maybe worth making an API test in case they are run there some day, or in
> case we make this mistake on another platform?
> 
> Code change looks fine but I suggest adding a test.

Thanks for reviewing! I will look into adding a test.
Comment 5 Per Arne Vollan 2020-02-10 14:46:39 PST 
Created attachment 390297 [details]
Patch
Comment 6 WebKit Commit Bot 2020-02-10 15:49:20 PST 
Comment on attachment 390297 [details]
Patch

Clearing flags on attachment: 390297

Committed r256225: <https://trac.webkit.org/changeset/256225>