Bug 207453 - Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT)
Summary: Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-09 22:31 PST by Fujii Hironori
Modified: 2020-02-13 21:53 PST (History)
12 users (show)

See Also:

Attachments
Patch (19.22 KB, patch)
2020-02-09 22:43 PST, Fujii Hironori 		ross.kirsling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-02-09 22:31:33 PST 
Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT)

I'm going to add a new rule build/export_macro to check-webkit-style in Bug 207380.
It detects style errors in existing code (Bug 207380 Comment 4).

See also:

  Bug 207380 – check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
  Bug 203876 – WEBCORE_TESTSUPPORT_EXPORT should be used only for WebCoreTestSupport, not for WebCore
Comment 1 Fujii Hironori 2020-02-09 22:43:16 PST 
Created attachment 390234 [details]
Patch
Comment 2 Ross Kirsling 2020-02-10 10:08:25 PST 
Comment on attachment 390234 [details]
Patch

r=me. I'm surprised there are so many!
Comment 3 Fujii Hironori 2020-02-11 18:01:13 PST 
Committed r256420: <https://trac.webkit.org/changeset/256420>
Comment 4 Radar WebKit Bug Importer 2020-02-11 18:02:17 PST 
<rdar://problem/59372199>