Bug 207449 - [WK2][Soup] Implement NetworkStorageSession::getAllCookies
Summary: [WK2][Soup] Implement NetworkStorageSession::getAllCookies
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pavel Feldman
Keywords: InRadar
Depends on:
Reported: 2020-02-09 20:29 PST by Pavel Feldman
Modified: 2020-02-12 18:14 PST (History)
8 users (show)

See Also:

Patch (1.75 KB, patch)
2020-02-09 20:31 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2020-02-09 20:29:51 PST
Getting is implemented for GTK/WPE ports.
Comment 1 Pavel Feldman 2020-02-09 20:31:30 PST
Created attachment 390228 [details]
Comment 2 Carlos Garcia Campos 2020-02-10 00:15:18 PST
Comment on attachment 390228 [details]

This looks good, but it seems to be deadcode for ports using libsoup. Why do you need this?  This is only used by cocoa API, I think.
Comment 3 Pavel Feldman 2020-02-11 13:10:27 PST
Thanks for looking into it.

This achieves feature parity with the Cocoa API in terms of raw cookie management. We'd like to be able to manage cookies on the datastore / processpool level over the remote debugging protocol. The harness / web inspector client is not there (yet) and it'll take time, so this does not make any tests green yet. But it looks innocent in terms of adding simple yet functional implementations for those.
Comment 4 Carlos Garcia Campos 2020-02-12 01:13:11 PST
Comment on attachment 390228 [details]

Ok, then. Thanks!
Comment 5 WebKit Commit Bot 2020-02-12 18:13:16 PST
Comment on attachment 390228 [details]

Clearing flags on attachment: 390228

Committed r256496: <https://trac.webkit.org/changeset/256496>
Comment 6 WebKit Commit Bot 2020-02-12 18:13:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-02-12 18:14:17 PST