207436 – Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h

Bug 207436 - Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h

Summary: Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to P...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Sam Weinig

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2020-02-08 17:34 PST by Sam Weinig
Modified:	2020-03-07 11:35 PST (History)
CC List:	14 users (show)

See Also:

Attachments
Patch (32.64 KB, patch) 2020-02-08 17:43 PST, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (62.38 KB, patch) 2020-03-05 19:18 PST, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (61.28 KB, patch) 2020-03-06 17:22 PST, Sam Weinig	darin: review+	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam Weinig 2020-02-08 17:34:30 PST

Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h

Comment 1 Sam Weinig 2020-02-08 17:43:02 PST Comment hidden (obsolete)

Created attachment 390189 [details]
Patch

Comment 2 Sam Weinig 2020-02-09 12:47:06 PST Comment hidden (obsolete)

Committed r256103: <https://trac.webkit.org/changeset/256103>

Comment 3 Radar WebKit Bug Importer 2020-02-09 12:48:15 PST

<rdar://problem/59296762>

Comment 4 Truitt Savell 2020-02-10 09:27:05 PST Comment hidden (obsolete)

Reverted r256103 for reason:

This patch is blocking the rollout of r256091

Committed r256183: <https://trac.webkit.org/changeset/256183>

Comment 5 Sam Weinig 2020-03-05 19:18:58 PST Comment hidden (obsolete)

Created attachment 392658 [details]
Patch

Comment 6 Sam Weinig 2020-03-06 17:22:54 PST

Created attachment 392815 [details]
Patch

Comment 7 Darin Adler 2020-03-06 19:01:28 PST

Comment on attachment 392815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392815&action=review

So glad you are doing this. Really not happy with FeatureDefines.xcconfig and wondering if we need it at all.

> Source/WTF/wtf/PlatformEnableCocoa.h:255
> +#if !defined(ENABLE_FAST_JIT_PERMISSIONS) && CPU(ARM64) && !(OS(TVOS) || OS(WATCHOS)) && USE(APPLE_INTERNAL_SDK)

Looks good.

I wonder about PLATFORM(APPLETV) vs. OS(TVOS); I think I’d almost always prefer OS(TVOS), but PLATFORM(APPLETV) seems much more common.

I wonder about PLATFORM(WATCHOS) vs. OS(WATCHOS).

Comment 8 Sam Weinig 2020-03-07 11:35:46 PST

Committed r258076: <https://trac.webkit.org/changeset/258076>