RESOLVED FIXED 207436
Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h 
https://bugs.webkit.org/show_bug.cgi?id=207436
Summary Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to P...
Sam Weinig
Reported 2020-02-08 17:34:30 PST
Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
Attachments
Patch (32.64 KB, patch)
2020-02-08 17:43 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (62.38 KB, patch)
2020-03-05 19:18 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (61.28 KB, patch)
2020-03-06 17:22 PST, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-02-08 17:43:02 PST Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-02-09 12:47:06 PST Comment hidden (obsolete)
Radar WebKit Bug Importer
Comment 3 2020-02-09 12:48:15 PST
<rdar://problem/59296762>
Truitt Savell
Comment 4 2020-02-10 09:27:05 PST Comment hidden (obsolete)
Sam Weinig
Comment 5 2020-03-05 19:18:58 PST Comment hidden (obsolete)
Sam Weinig
Comment 6 2020-03-06 17:22:54 PST
Created attachment 392815 [details] Patch
Darin Adler
Comment 7 2020-03-06 19:01:28 PST
Comment on attachment 392815 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392815&action=review So glad you are doing this. Really not happy with FeatureDefines.xcconfig and wondering if we need it at all. > Source/WTF/wtf/PlatformEnableCocoa.h:255 > +#if !defined(ENABLE_FAST_JIT_PERMISSIONS) && CPU(ARM64) && !(OS(TVOS) || OS(WATCHOS)) && USE(APPLE_INTERNAL_SDK) Looks good. I wonder about PLATFORM(APPLETV) vs. OS(TVOS); I think I’d almost always prefer OS(TVOS), but PLATFORM(APPLETV) seems much more common. I wonder about PLATFORM(WATCHOS) vs. OS(WATCHOS).
Sam Weinig
Comment 8 2020-03-07 11:35:46 PST
Committed r258076: <https://trac.webkit.org/changeset/258076>
Note You need to log in before you can comment on or make changes to this bug.