Bug 20743 - redefined WTF_USE_JSC macro
Summary: redefined WTF_USE_JSC macro
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2008-09-09 04:36 PDT by Csaba Osztrogonác
Modified: 2008-09-15 05:35 PDT (History)
0 users

See Also:

proposed patch (884 bytes, patch)
2008-09-09 04:43 PDT, Csaba Osztrogonác
eric: review-
Details | Formatted Diff | Diff
proposed patch (1.14 KB, patch)
2008-09-09 04:54 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2008-09-09 04:36:56 PDT
WebCore/WebCore.pro defines WTF_USE_JSC=1, assigned to compiler command line. But WebCore/config.h also defines WTF_USE_JSC: #define WTF_USE_JSC !WTF_USE_V8. The macro redifinig is warning according to gcc. I think it should be fixed. One way to remove defining WTF_USE_JSC from WebCore.pro. The other way to use #undef macro in config.h, if WTF_USE_JSC defined before.
Comment 1 Csaba Osztrogonác 2008-09-09 04:43:05 PDT
Created attachment 23290 [details]
proposed patch

Undef WTF_USE_JSC before redefining.
Comment 2 Csaba Osztrogonác 2008-09-09 04:54:44 PDT
Created attachment 23292 [details]
proposed patch

Defining unnecessary WTF_USE_JSC macro removed.
Comment 3 Mark Rowe (bdash) 2008-09-09 13:25:02 PDT
Please pick the patch that you feel is appropriate and set it for review.  The two you have provided appear to be mutually exclusive.  Please also include a ChangeLog entry.
Comment 4 Mark Rowe (bdash) 2008-09-09 13:25:54 PDT
My bad, you did include ChangeLog entries.  Please mark the patch that you feel is the right approach for review.
Comment 5 Csaba Osztrogonác 2008-09-09 13:36:48 PDT
Comment on attachment 23292 [details]
proposed patch

WTF_USE_JSC=1 defined by http://trac.webkit.org/changeset/36268 because of Qt/Windows build.
Comment 6 Csaba Osztrogonác 2008-09-09 13:41:49 PDT
(In reply to comment #4)
I marked one of my patyh for review. The other patch is bad as I mentioned in my previous remark.
Comment 7 Eric Seidel (no email) 2008-09-12 12:22:19 PDT
Comment on attachment 23290 [details]
proposed patch

The way we would normally do this is:

#ifndef WTF_USE_JSC
Comment 8 Csaba Osztrogonác 2008-09-15 05:35:29 PDT
This bug fixed by other, landed in r36439 (http://trac.webkit.org/changeset/36439)