Bug 207410 - [bmalloc] VMHeap can be merge into Heap
Summary: [bmalloc] VMHeap can be merge into Heap
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
Keywords: InRadar
Depends on:
Reported: 2020-02-07 14:45 PST by Basuke Suzuki
Modified: 2020-02-08 02:36 PST (History)
10 users (show)

See Also:

PATCH (14.40 KB, patch)
2020-02-07 15:14 PST, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2020-02-07 14:45:54 PST
I don't know about the history of VMHeap, but it has only one member function in it and Heap is the only client of that function. No member variable is defined. It does nothing special with its class. It is safe to merge the function into Heap.
Comment 1 Basuke Suzuki 2020-02-07 15:14:07 PST
Created attachment 390132 [details]
Comment 2 Yusuke Suzuki 2020-02-08 01:52:29 PST
Comment on attachment 390132 [details]

r=me, I think VMHeap is no longer necessary too.
Comment 3 WebKit Commit Bot 2020-02-08 02:35:44 PST
Comment on attachment 390132 [details]

Clearing flags on attachment: 390132

Committed r256088: <https://trac.webkit.org/changeset/256088>
Comment 4 WebKit Commit Bot 2020-02-08 02:35:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-02-08 02:36:14 PST