Bug 207405 - TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
Summary: TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-07 13:57 PST by Jonathan Bedard
Modified: 2020-02-07 15:39 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.08 KB, patch)
2020-02-07 13:59 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (1.19 KB, patch)
2020-02-07 14:48 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-02-07 13:57:14 PST
Our ActionSheet tests test behavior not applicable to Catalyst. Disable these tests on Catalyst.
Comment 1 Jonathan Bedard 2020-02-07 13:59:44 PST
Created attachment 390119 [details]
Patch
Comment 2 Wenson Hsieh 2020-02-07 14:38:22 PST
Comment on attachment 390119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390119&action=review

> Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm:29
> +#if PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST)

You should update the corresponding #endif as well.
Comment 3 Jonathan Bedard 2020-02-07 14:48:24 PST
Created attachment 390128 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2020-02-07 15:38:23 PST
Comment on attachment 390128 [details]
Patch for landing

Clearing flags on attachment: 390128

Committed r256074: <https://trac.webkit.org/changeset/256074>
Comment 5 WebKit Commit Bot 2020-02-07 15:38:24 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-07 15:39:18 PST
<rdar://problem/59276605>