Bug 207398 – Handle deprecated APIs in WKImagePreviewViewController

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

We are using some deprecated APIs in WKImagePreviewViewController and we need to allow them.

Not sure how our OpenSource build is working at the moment.

[Jonathan Bedard]

Created attachment 390114 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 390114 [details]
Patch

Clearing flags on attachment: 390114

Committed r256057: <https://trac.webkit.org/changeset/256057>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59272048>

[Alexey Proskuryakov]

Comment on attachment 390114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390114&action=review

> Source/WebKit/UIProcess/WKImagePreviewViewController.mm:98
> +ALLOW_DEPRECATED_DECLARATIONS_BEGIN
>  ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
>  - (NSArray<UIPreviewAction *> *)previewActionItems

Why is this right? Surely there is no need for ALLOW_DEPRECATED_DECLARATIONS_BEGIN around previewActionItems, because it's not even a declaration.

[Tim Horton]

Comment on attachment 390114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390114&action=review

>> Source/WebKit/UIProcess/WKImagePreviewViewController.mm:98
>>  - (NSArray<UIPreviewAction *> *)previewActionItems
> 
> Why is this right? Surely there is no need for ALLOW_DEPRECATED_DECLARATIONS_BEGIN around previewActionItems, because it's not even a declaration.

It could definitely be tighter (it's about things inside the method body), but also doesn't really matter?

[Alexey Proskuryakov]

Usually these annotate code that needs rework. If we don't care about precisely identifying such code, it would be easier to just disable deprecation warnings for the whole project.

Or are you saying that everything between these lines needs to be reworked?

[Tim Horton]

(In reply to Alexey Proskuryakov from comment #7)
> Usually these annotate code that needs rework. If we don't care about
> precisely identifying such code, it would be easier to just disable
> deprecation warnings for the whole project.
> 
> Or are you saying that everything between these lines needs to be reworked?

More than half, anyway.

[Tim Horton]

(In reply to Alexey Proskuryakov from comment #7)
> Usually these annotate code that needs rework. If we don't care about
> precisely identifying such code, it would be easier to just disable
> deprecation warnings for the whole project.

Also, it's ... 10 lines. This seems a little unnecessarily melodramatic :)

[Alexey Proskuryakov]

Excuses.