Bug 207390 - [iOS] Double tapping shouldn't scroll the page when the body has `overflow: hidden`
Summary: [iOS] Double tapping shouldn't scroll the page when the body has `overflow: h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-07 09:46 PST by Wenson Hsieh
Modified: 2020-02-07 15:25 PST (History)
6 users (show)

See Also:


Attachments
Patch (8.11 KB, patch)
2020-02-07 10:28 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (7.61 KB, patch)
2020-02-07 11:07 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Update 'Reviewed by' line again (7.64 KB, patch)
2020-02-07 11:40 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-02-07 09:46:12 PST
The page isn't scrollable with pan gestures anyways in this scenario, so it doesn't make sense that it's still scrollable by double tapping.

However, we need to make sure that we still allow scrolling when revealing focused editable elements (otherwise, they could be underlapped by the software keyboard).
Comment 1 Wenson Hsieh 2020-02-07 09:46:36 PST
<rdar://problem/56960774>
Comment 2 Wenson Hsieh 2020-02-07 10:28:39 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2020-02-07 11:07:26 PST Comment hidden (obsolete)
Comment 4 Wenson Hsieh 2020-02-07 11:40:53 PST
Created attachment 390110 [details]
Update 'Reviewed by' line again
Comment 5 WebKit Commit Bot 2020-02-07 15:25:49 PST
Comment on attachment 390110 [details]
Update 'Reviewed by' line again

Clearing flags on attachment: 390110

Committed r256072: <https://trac.webkit.org/changeset/256072>
Comment 6 WebKit Commit Bot 2020-02-07 15:25:51 PST
All reviewed patches have been landed.  Closing bug.