Bug 207388 - [Win] Two FileSystem API tests fail
Summary: [Win] Two FileSystem API tests fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-07 09:34 PST by Stephan Szabo
Modified: 2020-02-07 14:30 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.46 KB, patch)
2020-02-07 09:46 PST, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2020-02-07 09:34:08 PST 
FileSystemTest.UnicodeDirectoryName fails because directoryName takes off \ but not / from the ends of paths causing a mismatch with the expected result. As PathFindFileName appears to stop at either, we probably should remove either from the end.

FileSystemTest.GetFileMetadataSymlink has two issues.

* First, creating a symlink appears to be returning the wrong truth value for success because CreateSymbolicLinkW returns zero on failure and non-zero on success (https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-createsymboliclinkw).

* Second, GetFinalPathNameByHandleW with VOLUME_NAME_NT appears to return a path that FindFirstFileW fails to open (I get paths starting with something like "\Device\HarddiskVolume6\").
Comment 1 Stephan Szabo 2020-02-07 09:46:38 PST 
Created attachment 390092 [details]
Patch
Comment 2 WebKit Commit Bot 2020-02-07 14:29:22 PST 
Comment on attachment 390092 [details]
Patch

Clearing flags on attachment: 390092

Committed r256063: <https://trac.webkit.org/changeset/256063>
Comment 3 WebKit Commit Bot 2020-02-07 14:29:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-02-07 14:30:19 PST 
<rdar://problem/59273901>