Bug 207381 - Use ObjectIdentifier for WebRTC resolvers
Summary: Use ObjectIdentifier for WebRTC resolvers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-07 04:30 PST by youenn fablet
Modified: 2020-02-10 09:30 PST (History)
5 users (show)

See Also:

Attachments
Patch (26.97 KB, patch)
2020-02-07 04:33 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (26.59 KB, patch)
2020-02-07 06:19 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-07 04:30:51 PST 
Use ObjectIdentifier for WebRTC resolvers
Comment 1 youenn fablet 2020-02-07 04:33:47 PST 
Created attachment 390074 [details]
Patch
Comment 2 youenn fablet 2020-02-07 06:19:51 PST 
Created attachment 390076 [details]
Patch
Comment 3 youenn fablet 2020-02-07 09:57:56 PST 
Comment on attachment 390076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390076&action=review

> Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:121
> +        WebProcess::singleton().libWebRTCNetwork().resolver(makeObjectIdentifier<LibWebRTCResolverIdentifierType>(decoder.destinationID())).didReceiveMessage(connection, decoder);

I probably need to make it more robust since destinationID could be zero here.
Comment 4 WebKit Commit Bot 2020-02-10 09:29:50 PST 
Comment on attachment 390076 [details]
Patch

Clearing flags on attachment: 390076

Committed r256185: <https://trac.webkit.org/changeset/256185>
Comment 5 WebKit Commit Bot 2020-02-10 09:29:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-10 09:30:15 PST 
<rdar://problem/59313321>