RESOLVED FIXED 207370
macCatalyst: Unnecessary I-beam over images in editable areas 
https://bugs.webkit.org/show_bug.cgi?id=207370
Summary macCatalyst: Unnecessary I-beam over images in editable areas
Tim Horton
Reported 2020-02-06 17:27:00 PST
macCatalyst: Unnecessary I-beam over images in editable areas
Attachments
Patch (5.21 KB, patch)
2020-02-06 17:27 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-02-06 17:27:36 PST
Created attachment 390034 [details] Patch
Tim Horton
Comment 2 2020-02-06 17:27:38 PST
<rdar://problem/59235429>
WebKit Commit Bot
Comment 3 2020-02-06 19:30:47 PST
Comment on attachment 390034 [details] Patch Clearing flags on attachment: 390034 Committed r256005: <https://trac.webkit.org/changeset/256005>
WebKit Commit Bot
Comment 4 2020-02-06 19:30:49 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2020-02-07 12:14:03 PST
Comment on attachment 390034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390034&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2844 > + if (!node) > + return false; > + RenderObject *renderer = node->renderer(); > + if (!renderer) > + return false; > + return is<RenderReplaced>(*renderer); I’d replace these six lines with this one-liner: return node && is<RenderReplaced>(node->renderer()); Fixes the position of the "*" in "RenderObject *" by deleting it, takes advantage of the null checking already built into is<>, and I think is still easy to read and reason about.
Note You need to log in before you can comment on or make changes to this bug.