Bug 207359 – Add slot based test for the accelerated animations freezing bug (201048)

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antti Koivisto]

Fix had a simpler test case but it is good to add one for the original problem too.

[Antti Koivisto]

Created attachment 390004 [details]
patch

[Ryosuke Niwa]

Comment on attachment 390004 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390004&action=review

> LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:52
> +    // Put a named slot and assign an element to it.

These comments seem unnecessary? I can see that from the code.

> LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:60
> +    // Create another named slot and assign another element to it.

Ditto.

> LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:64
> +    // Start animation in the seconds slot.

Ditto.

> LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:79
> +    // Wait until animation has progressed some before snapshotting the test result.

Whereas this explanation is kind of useful.

[Antti Koivisto]

> These comments seem unnecessary? I can see that from the code.

They were in the original test, I suppose the author found them helpful.

[Ryosuke Niwa]

(In reply to Antti Koivisto from comment #3)
> > These comments seem unnecessary? I can see that from the code.
> 
> They were in the original test, I suppose the author found them helpful.

Was it imported from somewhere?? If so, we need to give a credit.

[Ryosuke Niwa]

Comment on attachment 390004 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390004&action=review

> LayoutTests/ChangeLog:10
> +        Based on the original test by Tim Guan-tin Chien.

Ah, I missed this line.

[WebKit Commit Bot]

Comment on attachment 390004 [details]
patch

Clearing flags on attachment: 390004

Committed r255996: <https://trac.webkit.org/changeset/255996>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59246972>