Bug 207356 - [JSC] CodeBlock::shrinkToFit should shrink m_constantRegisters and m_constantsSourceCodeRepresentation in 64bit architectures
Summary: [JSC] CodeBlock::shrinkToFit should shrink m_constantRegisters and m_constant...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 207369
Blocks:
  Show dependency tree / graph
 
Reported: 2020-02-06 14:35 PST by Yusuke Suzuki
Modified: 2020-02-07 02:06 PST (History)
8 users (show)

See Also:

Attachments
Patch (11.42 KB, patch)
2020-02-06 14:37 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (11.60 KB, patch)
2020-02-06 14:40 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-02-06 14:35:44 PST 
[JSC] CodeBlock::shrinkToFit should shrink m_constantRegisters and m_constantsSourceCodeRepresentation in 64bit architectures
Comment 1 Yusuke Suzuki 2020-02-06 14:37:45 PST 
Created attachment 389999 [details]
Patch
Comment 2 Yusuke Suzuki 2020-02-06 14:40:40 PST 
Created attachment 390001 [details]
Patch
Comment 3 Mark Lam 2020-02-06 15:15:15 PST 
Comment on attachment 390001 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2020-02-06 15:25:06 PST 
Committed r255987: <https://trac.webkit.org/changeset/255987>
Comment 5 Radar WebKit Bug Importer 2020-02-06 15:26:16 PST 
<rdar://problem/59239933>
Comment 6 Ryan Haddad 2020-02-06 17:24:08 PST 
This appears to have caused layout tests to exit early due to excessive timeouts, and caused test262 to time out after 20m without output

Layout tests: 
https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Tests/builds/2755

test262:
https://build.webkit.org/builders/Apple-Catalina-Debug-Test262-Tests/builds/855
Comment 7 WebKit Commit Bot 2020-02-06 17:25:23 PST 
Re-opened since this is blocked by bug 207369
Comment 8 Yusuke Suzuki 2020-02-07 02:06:30 PST 
Committed r256015: <https://trac.webkit.org/changeset/256015>