Bug 207351 – Cleanup and promote WKContentWorld and its clients in WKWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Brady Eidson]

Cleanup and promote WKContentWorld and its clients in WKWebView

[Brady Eidson]

Created attachment 389993 [details]
Patch

[Alex Christensen]

Comment on attachment 389993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389993&action=review

> Source/WebKit/Shared/Cocoa/APIObject.mm:-351
> -        wrapper = [_WKContentWorld alloc];

There were no clients of this old class, right?  Otherwise we would need a wrapper to keep binary compatibility.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:828
> +- (void)callAsyncJavaScript:(NSString *)javaScriptString arguments:(NSDictionary<NSString *, id> *)arguments inContentWorld:(WKContentWorld *)contentWorld completionHandler:(void (^)(id, NSError *error))completionHandler

The JavaScript is not necessarily Async.  Could we remove that?
If not, do we want to write out Asynchronous?

[Brady Eidson]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 389993 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389993&action=review
> 
> > Source/WebKit/Shared/Cocoa/APIObject.mm:-351
> > -        wrapper = [_WKContentWorld alloc];
> 
> There were no clients of this old class, right?  Otherwise we would need a
> wrapper to keep binary compatibility.

No clients, correct.

> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:828
> > +- (void)callAsyncJavaScript:(NSString *)javaScriptString arguments:(NSDictionary<NSString *, id> *)arguments inContentWorld:(WKContentWorld *)contentWorld completionHandler:(void (^)(id, NSError *error))completionHandler
> 
> The JavaScript is not necessarily Async.  Could we remove that?
> If not, do we want to write out Asynchronous?

This name is what internal discussion settled on.

[WebKit Commit Bot]

Comment on attachment 389993 [details]
Patch

Clearing flags on attachment: 389993

Committed r255998: <https://trac.webkit.org/changeset/255998>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59247330>

[Alex Christensen]

Comment on attachment 389993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389993&action=review

> Source/WebKit/ChangeLog:17
> +        * UIProcess/API/Cocoa/WKContentWorld.h: Renamed from Source/WebKit/UIProcess/API/Cocoa/_WKContentWorld.h.

You should add this to WebKit.h.

[Brady Eidson]

Reopening to attach new patch.

[Brady Eidson]

Created attachment 390116 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 390116 [details]
Patch

Rejecting attachment 390116 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 390116, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/13318758

[Alex Christensen]

http://trac.webkit.org/r256312