WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
207341
[WK2][iOS] Add WKWebviewConfiguration SPI to run client navigations at foreground priority, even if the view is background
https://bugs.webkit.org/show_bug.cgi?id=207341
Summary
[WK2][iOS] Add WKWebviewConfiguration SPI to run client navigations at foregr...
Chris Dumez
Reported
2020-02-06 10:23:11 PST
Add WKWebviewConfiguration SPI to run client navigations at foreground priority, even if the view is background.
Attachments
Patch
(17.92 KB, patch)
2020-02-06 12:35 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(19.20 KB, patch)
2020-02-06 15:01 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2020-02-06 10:23:23 PST
<
rdar://problem/59227077
>
Chris Dumez
Comment 2
2020-02-06 12:35:58 PST
Created
attachment 389981
[details]
Patch
Geoffrey Garen
Comment 3
2020-02-06 14:36:02 PST
Comment on
attachment 389981
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=389981&action=review
r=me
> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:153 > + bool isViewService = WTF::processHasEntitlement("com.apple.UIKit.vends-view-services") && [[m_webView window] _isHostedInAnotherProcess]; > + if (_UIApplicationIsExtension() || isViewService) {
Might be nicer to use applicationType() here.
Chris Dumez
Comment 4
2020-02-06 14:42:23 PST
(In reply to Geoffrey Garen from
comment #3
)
> Comment on
attachment 389981
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=389981&action=review
> > r=me > > > Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:153 > > + bool isViewService = WTF::processHasEntitlement("com.apple.UIKit.vends-view-services") && [[m_webView window] _isHostedInAnotherProcess]; > > + if (_UIApplicationIsExtension() || isViewService) { > > Might be nicer to use applicationType() here.
applicationType() is in ApplicationStateTracker.mm, would you like me to move it somewhere else so I can reuse it here?
Chris Dumez
Comment 5
2020-02-06 15:01:11 PST
Created
attachment 390009
[details]
Patch
Chris Dumez
Comment 6
2020-02-06 16:44:39 PST
Comment on
attachment 390009
[details]
Patch Clearing flags on attachment: 390009 Committed
r255992
: <
https://trac.webkit.org/changeset/255992
>
Chris Dumez
Comment 7
2020-02-06 16:44:41 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug