Bug 207332 - Filter out TURN/STUN .local URLs from a RTCPeerConnection iceServers list
Summary: Filter out TURN/STUN .local URLs from a RTCPeerConnection iceServers list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-06 06:56 PST by youenn fablet
Modified: 2020-02-07 08:41 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.83 KB, patch)
2020-02-06 07:41 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (12.98 KB, patch)
2020-02-06 23:58 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (13.04 KB, patch)
2020-02-07 06:23 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-06 06:56:52 PST 
Filter out TURN/STUN .local URLs from a RTCPeerConnection iceServers list
Comment 1 youenn fablet 2020-02-06 07:41:46 PST 
Created attachment 389956 [details]
Patch
Comment 2 Eric Carlson 2020-02-06 08:04:23 PST 
Comment on attachment 389956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389956&action=review

> Source/WebCore/ChangeLog:8
> +        Filter out TURN/STUN .local URLs from a RTCPeerConnection iceServers list
> +        https://bugs.webkit.org/show_bug.cgi?id=207332
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: webrtc/stun-server-filtering.html

It would be nice to have a comment explaining why this change is necessary.
Comment 3 youenn fablet 2020-02-06 23:58:13 PST 
Created attachment 390060 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2020-02-07 02:02:30 PST 
Comment on attachment 390060 [details]
Patch for landing

Rejecting attachment 390060 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 390060, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13318463
Comment 5 youenn fablet 2020-02-07 06:23:56 PST 
Created attachment 390077 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2020-02-07 08:40:23 PST 
Comment on attachment 390077 [details]
Patch for landing

Clearing flags on attachment: 390077

Committed r256024: <https://trac.webkit.org/changeset/256024>
Comment 7 WebKit Commit Bot 2020-02-07 08:40:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-02-07 08:41:16 PST 
<rdar://problem/59260337>