Bug 207326 – Do not process newly gathered ICE candidates if document is suspended

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Do not process newly gathered ICE candidates if document is suspended

[youenn fablet]

<rdar://problem/57336453>

[youenn fablet]

Created attachment 389943 [details]
Patch

[Eric Carlson]

Comment on attachment 389943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389943&action=review

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:441
> +        ALWAYS_LOG(LOGIDENTIFIER, "Gathered ice candidate:", sdp);

"LOGIDENTIFIER" produces an unexpected method name when executed inside of a lambda, so you might want to pass the value as a parameter.

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 389943 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389943&action=review
> 
> > Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:441
> > +        ALWAYS_LOG(LOGIDENTIFIER, "Gathered ice candidate:", sdp);
> 
> "LOGIDENTIFIER" produces an unexpected method name when executed inside of a
> lambda, so you might want to pass the value as a parameter.

Makes sense will fix it.

[Alex Christensen]

Comment on attachment 389943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389943&action=review

> Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:95
> +    int m_delay { 0 };

unsigned.
Also, delay makes me think "Seconds" but this is run loop iterations.

[youenn fablet]

Created attachment 390058 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 390058 [details]
Patch for landing

Clearing flags on attachment: 390058

Committed r256009: <https://trac.webkit.org/changeset/256009>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.