Bug 207304 - resulsdbpy: Fix unit tests
Summary: resulsdbpy: Fix unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-05 15:40 PST by Jonathan Bedard
Modified: 2020-02-05 17:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.07 KB, patch)
2020-02-05 15:51 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-02-05 15:40:00 PST 
We have a few broken unit tests when using actual Cassandra (I tend to avoid running these tests because they are much more expensive then the mock versions)
Comment 1 Jonathan Bedard 2020-02-05 15:51:13 PST 
Created attachment 389891 [details]
Patch
Comment 2 Jonathan Bedard 2020-02-05 15:52:35 PST 
100% testing code, none of this is actually serving content on results.webkit.org
Comment 3 Aakash Jain 2020-02-05 15:57:54 PST 
This reminds me that we should run these tests in EWS. <rdar://problem/55109441>
Comment 4 Jonathan Bedard 2020-02-05 16:01:51 PST 
(In reply to Aakash Jain from comment #3)
> This reminds me that we should run these tests in EWS.
> <rdar://problem/55109441>

Yes, I was going to do that next, actually. We need some Pip packages on our EWS machine for it.
Comment 5 WebKit Commit Bot 2020-02-05 17:13:52 PST 
Comment on attachment 389891 [details]
Patch

Clearing flags on attachment: 389891

Committed r255883: <https://trac.webkit.org/changeset/255883>
Comment 6 WebKit Commit Bot 2020-02-05 17:13:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-02-05 17:14:16 PST 
<rdar://problem/59208735>