Bug 207275 - Adopt MTOverrideShouldPlayHDRVideo()
Summary: Adopt MTOverrideShouldPlayHDRVideo()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-05 10:07 PST by Jer Noble
Modified: 2020-02-05 17:03 PST (History)
7 users (show)

See Also:

Attachments
Patch (9.50 KB, patch)
2020-02-05 10:19 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (9.47 KB, patch)
2020-02-05 10:54 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-02-05 10:07:22 PST 
Adopt MTOverrideShouldPlayHDRVideo()
Comment 1 Jer Noble 2020-02-05 10:09:31 PST 
<rdar://problem/58837093>
Comment 2 Jer Noble 2020-02-05 10:19:56 PST 
Created attachment 389828 [details]
Patch
Comment 3 Eric Carlson 2020-02-05 10:32:02 PST 
Comment on attachment 389828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389828&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:936
> +    WebCore::setScreenProperties(properties);

The namespace shouldn't be necessary

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:945
> +        WebCore::setShouldOverrideScreenSupportsHighDynamicRange(false, false);

Ditto

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:952
> +    WebCore::setShouldOverrideScreenSupportsHighDynamicRange(true, allPagesAreOnHDRScreens);

Ditto
Comment 4 Jer Noble 2020-02-05 10:54:34 PST 
Created attachment 389830 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-02-05 17:03:05 PST 
Comment on attachment 389830 [details]
Patch for landing

Clearing flags on attachment: 389830

Committed r255881: <https://trac.webkit.org/changeset/255881>
Comment 6 WebKit Commit Bot 2020-02-05 17:03:07 PST 
All reviewed patches have been landed.  Closing bug.