Bug 207248 – [Web Inspector][WinCairo] Selecting an error message in Console causes "TypeError:​ selection.focusNode.closest is not a function."

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Fujii Hironori]

[Web Inspector][WinCairo] The error "TypeError:​ selection.focusNode.closest is not a function." happens by selecting an error message

I tested with WinCairo WK2, trunk, r255482.

1. Start MiniBrowser
2. Open Web Inspector
3. Open Console Tab
4. Enter "foo"
5. An error message "ReferenceError: Can't find variable: foo" is output
6. Press left mouse button on the string of the error message
6. Drug the mouse
7. "TypeError:​ selection.focusNode.closest is not a function." happens

These uncaught exceptions caused the problem:
TypeError:​ selection.focusNode.closest is not a function. (In 'selection.focusNode.closest("." + WI.LogContentView.ItemWrapperStyleClassName)​', 'selection.focusNode.closest' is undefined)​ (at LogContentView.js:​552:​54)​
    _mousemove @ LogContentView.js:​552:​54
    handleEvent @ LogContentView.js:​653:​28

I don't see this issue in Mac port.

[Stephan Szabo]

Hmm, Devin Rousso seems to have reported similar for mac at https://bugs.webkit.org/show_bug.cgi?id=198594

[Fujii Hironori]

Looks a same issue. Thanks. But surprisingly Mac port doesn't reproduce the issue even this Bug 198594's test case on my Mac. 🤔

[Fujii Hironori]

selection.focusNode is a Text node at the time. closest is a method of Element.

[Fujii Hironori]

The code was added by r242174 (Bug 173747).

[Fujii Hironori]

Created attachment 389941 [details]
Patch

[Devin Rousso]

Comment on attachment 389941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389941&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:552
> +                var focusElement = selection.focusNode;

Style: we prefer using `let`

[Fujii Hironori]

Created attachment 390037 [details]
Patch for landing

Thank you for the reveiw.

[Fujii Hironori]

Committed r256006: <https://trac.webkit.org/changeset/256006>

[Radar WebKit Bug Importer]

<rdar://problem/59249046>