Bug 207231 - Fix Mac CMake build
Summary: Fix Mac CMake build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-04 14:57 PST by Alex Christensen
Modified: 2020-02-04 18:19 PST (History)
12 users (show)

See Also:

Attachments
patch (15.66 KB, patch)
2020-02-04 15:00 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-02-04 14:57:48 PST 
Fix some bit rot.
Comment 1 Alex Christensen 2020-02-04 15:00:16 PST 
Created attachment 389715 [details]
patch
Comment 2 Alex Christensen 2020-02-04 15:36:37 PST 
http://trac.webkit.org/r255709
Comment 3 Radar WebKit Bug Importer 2020-02-04 15:37:19 PST 
<rdar://problem/59168617>
Comment 4 Ryan Haddad 2020-02-04 17:39:41 PST 
Internal build fix in https://trac.webkit.org/changeset/255779/webkit
Comment 5 Darin Adler 2020-02-04 18:19:48 PST 
Comment on attachment 389715 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389715&action=review

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:133
> +#if __has_feature(objc_arc)
>      __weak WKWebView *weakWebView = _webView;
> +#else
> +    WKWebView *weakWebView = _webView;
> +#endif

I don’t understand this at all. This file is not ARC-compatible; it has a [super dealloc] call and calls to the release method.

What’s the story here?