Bug 207227 – Non-unified build fixes early February 2020 edition

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adrian Perez]

We'll keep having issues now and then until I get round to
continue work on #206737 ¬_¬

[Adrian Perez]

Created attachment 389708 [details]
Patch

[Don Olmstead]

Comment on attachment 389708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389708&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Non-unified build fixes early January 2020 edition

We're in February

[Adrian Perez]

(In reply to Don Olmstead from comment #2)
> Comment on attachment 389708 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389708&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        Non-unified build fixes early January 2020 edition
> 
> We're in February

So true 🤦‍♂️️

[Don Olmstead]

Comment on attachment 389708 [details]
Patch

I feel like these build fixes can be unreviewed. Going to r+ cause its fine but cq- because the Changelogs have the previous title

[Adrian Perez]

Created attachment 389724 [details]
Patch for landing

[Adrian Perez]

(In reply to Don Olmstead from comment #4)
> Comment on attachment 389708 [details]
> Patch
> 
> I feel like these build fixes can be unreviewed. Going to r+ cause its fine
> but cq- because the Changelogs have the previous title

Sure, I will do them as unreviewed build fixes from now on unless there
is something that I am not 100% sure about :)

Thanks!

[WebKit Commit Bot]

Comment on attachment 389724 [details]
Patch for landing

Clearing flags on attachment: 389724

Committed r255711: <https://trac.webkit.org/changeset/255711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59170022>