WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
207209
Regression (~
r252261
): [ Mac wk2 ] inspector/heap/getPreview.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207209
Summary
Regression (~r252261): [ Mac wk2 ] inspector/heap/getPreview.html is flaky fa...
Jason Lawrence
Reported
2020-02-04 09:59:13 PST
inspector/heap/getPreview.html Description: This test is flaky failing on Mac wk2. It appears to show a regression at 252273. History:
https://results.webkit.org/?suite=layout-tests&test=inspector%2Fheap%2FgetPreview.html&platform=mac&limit=50000
Diff: I was not able to gather a diff.
Attachments
Update Test Expectations
(1.90 KB, patch)
2020-02-04 11:46 PST
,
Jason Lawrence
no flags
Details
Formatted Diff
Diff
Update Test Expectations
(1.93 KB, patch)
2020-02-04 12:00 PST
,
Jason Lawrence
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-02-04 09:59:36 PST
<
rdar://problem/59152840
>
Jason Lawrence
Comment 2
2020-02-04 11:46:40 PST
Created
attachment 389685
[details]
Update Test Expectations
Jason Lawrence
Comment 3
2020-02-04 11:47:14 PST
Here's a diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/heap/getPreview-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/heap/getPreview-actual.txt @@ -29,23 +29,12 @@ OBJECT PREVIEW: { "type": "object", "description": "Map", - "lossless": true, - "subtype": "map", - "overflow": false, - "properties": [], - "size": 1, - "entries": [ + "lossless": false, + "properties": [ { - "key": { - "type": "string", - "description": "key", - "lossless": true - }, - "value": { - "type": "string", - "description": "value", - "lossless": true - } + "name": "Symbol(Symbol.toStringTag)", + "type": "string", + "value": "Map" } ] }
Jason Lawrence
Comment 4
2020-02-04 12:00:50 PST
Created
attachment 389687
[details]
Update Test Expectations
Truitt Savell
Comment 5
2020-02-04 12:01:47 PST
Comment on
attachment 389687
[details]
Update Test Expectations Clearing flags on attachment: 389687 Committed
r255690
: <
https://trac.webkit.org/changeset/255690
>
Jacob Uphoff
Comment 6
2020-02-04 14:12:17 PST
I ran this test in iterations x5000 and did not reproduce a failure.
Jason Lawrence
Comment 7
2020-02-05 16:15:43 PST
I was able to reproduce this issue with 255856 using the following command. run-webkit-tests --root xxx inspector/heap/getPreview.html --iterations 5000 -f --exit-after-n-failures 5 -g --force --time-out-ms 10000 [15/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [17/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [18/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [22/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [23/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) Exiting early after 5 failures. 20 tests run. 15 tests ran as expected, 5 didn't (4980 didn't run):
Joseph Pecoraro
Comment 8
2020-02-05 16:26:29 PST
Hmm, I don't like the idea of papering over this potential issue. It sounds like a (In reply to Jason Lawrence from
comment #3
)
> Here's a diff: > > --- > /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/ > inspector/heap/getPreview-expected.txt > +++ > /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/ > inspector/heap/getPreview-actual.txt > @@ -29,23 +29,12 @@ > OBJECT PREVIEW: { > "type": "object", > "description": "Map", > - "lossless": true, > - "subtype": "map", > - "overflow": false, > - "properties": [], > - "size": 1, > - "entries": [ > + "lossless": false, > + "properties": [ > { > - "key": { > - "type": "string", > - "description": "key", > - "lossless": true > - }, > - "value": { > - "type": "string", > - "description": "value", > - "lossless": true > - } > + "name": "Symbol(Symbol.toStringTag)", > + "type": "string", > + "value": "Map" > } > ] > }
Does this always fail this way? Can we just rebaseline?
Alexey Proskuryakov
Comment 9
2020-02-05 23:35:46 PST
> 15 tests ran as expected, 5 didn't (4980 didn't run):
This suggests that no, we cannot rebaseline.
Alexey Proskuryakov
Comment 10
2020-02-05 23:41:42 PST
I don't see any failures at all before early November (roughly
r252261
), although there were always many timeouts.
Jacob Uphoff
Comment 11
2020-02-10 08:20:57 PST
Corrected test expectations on
r256174
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug