Bug 207194 – REGRESSION: [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Jason Lawrence]

fast/scrolling/ios/scroll-events-back-forward.html

Description:
This test is flaky failing on iOS. It has a possible regression point of 255234.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fscrolling%2Fios%2Fscroll-events-back-forward.html&platform=ios&limit=50000

Diff:
--- /Volumes/Data/slave/ipados-simulator-13-debug-tests-wk2/build/layout-test-results/fast/scrolling/ios/scroll-events-back-forward-expected.txt
+++ /Volumes/Data/slave/ipados-simulator-13-debug-tests-wk2/build/layout-test-results/fast/scrolling/ios/scroll-events-back-forward-actual.txt
@@ -5,7 +5,7 @@
 
 pageshow 0
 pageshow 1
-PASS scrollEventCount is 1
+FAIL scrollEventCount should be 1. Was 0.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Radar WebKit Bug Importer]

<rdar://problem/59148073>

[Jason Lawrence]

I am able to reproduce this issue with run-webkit-tests using iterations. It failed 5x in 951 runs.

[Jason Lawrence]

Created attachment 389657 [details]
Update Test Expectations

[Truitt Savell]

Comment on attachment 389657 [details]
Update Test Expectations

Clearing flags on attachment: 389657

Committed r255672: <https://trac.webkit.org/changeset/255672>

[Alexey Proskuryakov]

I see a slightly earlier failure on 2019-11-08 on internal tests, but yes, it's clearly a regression around that date. The test never failed before that date, and became a frequent failure afterwards.

Given that the test uses a 10 ms timer that may race with events, this may be a bad test, but going from zero to many failures suggests something more substantial to me.

[Chris Dumez]

Created attachment 389813 [details]
WIP Patch

[Chris Dumez]

Created attachment 389814 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 389814 [details]
Patch

Rejecting attachment 389814 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 389814, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=389814&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=207194&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 389814 from bug 207194.
Fetching: https://bugs.webkit.org/attachment.cgi?id=389814
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Wenson Hsieh']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 4 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt
patching file LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html
patching file LayoutTests/platform/ios-wk2/TestExpectations
Hunk #1 FAILED at 1373.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/ios-wk2/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Wenson Hsieh']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 4 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt
patching file LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html
patching file LayoutTests/platform/ios-wk2/TestExpectations
Hunk #1 FAILED at 1373.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/ios-wk2/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Wenson Hsieh']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   f3e0ae51dfc..25a039e8ba7  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 255820 = f3e0ae51dfc689d072afbdcc9d1ea2e0f262d484
r255821 = 89a32102035c0a9464a9ffd164e294fd08d8505d
r255822 = 25a039e8ba7905db1ecd9e401a94d665cd89b198
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13317079

[Chris Dumez]

Committed r255825: <https://trac.webkit.org/changeset/255825>

[Jason Lawrence]

Reopening to attach new patch.

[Jason Lawrence]

Created attachment 389959 [details]
Update Test Expectations

[Truitt Savell]

This was reopened in error