Bug 207175 - WPT test importer imports rel="mismatch" as the reference
Summary: WPT test importer imports rel="mismatch" as the reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks: 207734 232663
  Show dependency tree / graph
 
Reported: 2020-02-03 18:26 PST by Carlos Alberto Lopez Perez
Modified: 2022-10-07 10:50 PDT (History)
9 users (show)

See Also:

Attachments
Patch (10.66 KB, patch)
2021-11-08 06:15 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch (10.89 KB, patch)
2021-11-08 06:53 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-02-03 18:26:44 PST 
Some WPT tests use <link rel="mismatch" href=...> to specify a reference that shouldn't match.
On WPT this can be used along with other <link rel="match" ...> references or it can be used alone.

See for example the test: https://github.com/web-platform-tests/wpt/blob/master/css/css-fonts/standard-font-family-20.html

This test was imported on r255351 but the WebKit W3C test importer imported the mismatch as the reference causing the test to fail (see bug 206881)

Other tests are likely affected by this, the one above its just an example.
Comment 1 Radar WebKit Bug Importer 2020-09-21 15:38:23 PDT 
<rdar://problem/69332102>
Comment 2 Manuel Rego Casasnovas 2021-11-08 06:15:31 PST 
Created attachment 443540 [details]
Patch
Comment 3 Manuel Rego Casasnovas 2021-11-08 06:53:11 PST 
Created attachment 443542 [details]
Patch
Comment 4 EWS 2021-11-08 10:45:56 PST 
Committed r285414 (243971@main): <https://commits.webkit.org/243971@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443542 [details].
Comment 5 Myles C. Maxfield 2021-11-08 13:29:39 PST 
OMG YES!!!

Thank you soooo much!!!