Bug 207172 - [JSC] Use PackedPtr for VariableEnvironment
Summary: [JSC] Use PackedPtr for VariableEnvironment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-03 17:53 PST by Yusuke Suzuki
Modified: 2020-02-03 20:23 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.29 KB, patch)
2020-02-03 17:54 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-02-03 17:53:18 PST 
[JSC] Use PackedCellPtr for VariableEnvironment
Comment 1 Yusuke Suzuki 2020-02-03 17:54:10 PST 
Created attachment 389608 [details]
Patch
Comment 2 Mark Lam 2020-02-03 18:05:47 PST 
Comment on attachment 389608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389608&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +        * runtime/CachedTypes.cpp:
> +        (JSC::CachedRefPtr::encode):
> +        (JSC::CachedRefPtr::decode const):

Your ChangeLog and title doesn't seem to include changes in CachedTypes.  Is this intended to be part of this patch?  If so, can you add a small blurb in the ChangeLog or update the title?
Comment 3 Yusuke Suzuki 2020-02-03 20:16:59 PST 
Comment on attachment 389608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389608&action=review

>> Source/JavaScriptCore/ChangeLog:13
>> +        (JSC::CachedRefPtr::decode const):
> 
> Your ChangeLog and title doesn't seem to include changes in CachedTypes.  Is this intended to be part of this patch?  If so, can you add a small blurb in the ChangeLog or update the title?

Fixed. This is just because CachedTypes should handle PackedPtr since changed data structures are encoded.
Comment 4 Yusuke Suzuki 2020-02-03 20:22:36 PST 
Committed r255659: <https://trac.webkit.org/changeset/255659>
Comment 5 Radar WebKit Bug Importer 2020-02-03 20:23:15 PST 
<rdar://problem/59137576>