RESOLVED FIXED 207168
[PlayStation] Add WebKit API files 
https://bugs.webkit.org/show_bug.cgi?id=207168
Summary [PlayStation] Add WebKit API files
Don Olmstead
Reported 2020-02-03 17:21:30 PST
and make sure it'll all build.
Attachments
Patch (9.47 KB, patch)
2020-02-03 18:09 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (10.35 KB, patch)
2020-02-03 18:17 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-02-03 18:09:14 PST Comment hidden (obsolete)
Don Olmstead
Comment 2 2020-02-03 18:17:02 PST
Created attachment 389612 [details] Patch
Don Olmstead
Comment 3 2020-02-03 18:25:14 PST
Style errors are just due to the style checker not realizing in the API C directories include guards should be used. Other than that I think this is good to go.
Darin Adler
Comment 4 2020-02-04 08:39:45 PST
(In reply to Don Olmstead from comment #3) > Style errors are just due to the style checker not realizing in the API C > directories include guards should be used. Other than that I think this is > good to go. I think the style checker has machinery for rules like that, used for GTK bindings directories for example. We should fix that in the style checker. I personally haven’t made changes to python scripts so don’t know how to do it myself but lots of WebKit contributors know how.
Konstantin Tokarev
Comment 5 2020-02-04 08:43:18 PST
These rulese live in Tools/Scripts/webkitpy/style/checker.py
Don Olmstead
Comment 6 2020-02-04 09:28:10 PST
(In reply to Darin Adler from comment #4) > (In reply to Don Olmstead from comment #3) > > Style errors are just due to the style checker not realizing in the API C > > directories include guards should be used. Other than that I think this is > > good to go. > > I think the style checker has machinery for rules like that, used for GTK > bindings directories for example. We should fix that in the style checker. I > personally haven’t made changes to python scripts so don’t know how to do it > myself but lots of WebKit contributors know how. Opened https://bugs.webkit.org/show_bug.cgi?id=207205 for the work. Other than that is this ok to land Darin?
Darin Adler
Comment 7 2020-02-04 09:56:03 PST
Comment on attachment 389612 [details] Patch Seems OK, I guess. Not sure why the empty WKView.h is a good idea.
Don Olmstead
Comment 8 2020-02-04 10:00:18 PST
(In reply to Darin Adler from comment #7) > Comment on attachment 389612 [details] > Patch > > Seems OK, I guess. Not sure why the empty WKView.h is a good idea. We are planning on filling it all out in subsequent patches.
WebKit Commit Bot
Comment 9 2020-02-04 10:43:43 PST
Comment on attachment 389612 [details] Patch Clearing flags on attachment: 389612 Committed r255685: <https://trac.webkit.org/changeset/255685>
WebKit Commit Bot
Comment 10 2020-02-04 10:43:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2020-02-04 10:44:18 PST
<rdar://problem/59154773>
Note You need to log in before you can comment on or make changes to this bug.