Bug 20714 - Resizing Gmail inbox vertically results in whitespace at the bottom of the window (caused by a CSS error)
Summary: Resizing Gmail inbox vertically results in whitespace at the bottom of the wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://mail.google.com/
Keywords: GoogleBug, HasReduction, InRadar
Depends on:
Blocks:
 
Reported: 2008-09-08 01:02 PDT by Darin Fisher (:fishd, Google)
Modified: 2008-09-16 10:34 PDT (History)
3 users (show)

See Also:


Attachments
reduction (304 bytes, text/html)
2008-09-08 01:03 PDT, Darin Fisher (:fishd, Google)
no flags Details
reduction: frame source (click the other one) (324 bytes, text/html)
2008-09-08 01:07 PDT, Darin Fisher (:fishd, Google)
no flags Details
reduction: top frame source (click on me) (374 bytes, text/html)
2008-09-08 01:08 PDT, Darin Fisher (:fishd, Google)
no flags Details
Reduction (549 bytes, text/html)
2008-09-08 07:28 PDT, mitz
no flags Details
Correct reduction (559 bytes, text/html)
2008-09-15 17:29 PDT, mitz
no flags Details
Patch for this bug and bug 15384 (45.50 KB, patch)
2008-09-15 18:32 PDT, mitz
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2008-09-08 01:02:16 PDT
Resizing Gmail inbox vertically results in whitespace at the bottom of the window (caused by a CSS error).  NOTE: if you resize horizontally, then this problem does not exist.

See the reduction that I am about to post.
Comment 1 Darin Fisher (:fishd, Google) 2008-09-08 01:03:02 PDT
Created attachment 23241 [details]
reduction
Comment 2 Darin Fisher (:fishd, Google) 2008-09-08 01:04:17 PDT
Comment on attachment 23241 [details]
reduction

oops.. let me try that again.
Comment 3 Darin Fisher (:fishd, Google) 2008-09-08 01:07:01 PDT
Created attachment 23242 [details]
reduction: frame source (click the other one)
Comment 4 Darin Fisher (:fishd, Google) 2008-09-08 01:08:42 PDT
Created attachment 23243 [details]
reduction: top frame source (click on me)
Comment 5 Darin Fisher (:fishd, Google) 2008-09-08 01:11:05 PDT
If you open attachment 23243 [details], and then resize the window in the vertical direction, increasing the size of the window, you should notice that it does not paint the background properly.
Comment 6 Maciej Stachowiak 2008-09-08 01:13:34 PDT
FWIW this is reproducible on Mac as well, but you have to be careful to resize vertical only. You get a white stripe at the bottom. If you resize horizontally even a little the problem fixes itself.
Comment 7 mitz 2008-09-08 07:26:49 PDT
<rdar://problem/5985669>
Comment 8 mitz 2008-09-08 07:28:29 PDT
Created attachment 23257 [details]
Reduction
Comment 9 mitz 2008-09-08 07:31:37 PDT
Might need to do something similar to the WIP patch attached to bug 15384.
Comment 10 mitz 2008-09-15 17:29:40 PDT
Created attachment 23451 [details]
Correct reduction

While behavior with attachment 23257 [details] is buggy, it does not reflect what happens on Gmail.
Comment 11 mitz 2008-09-15 18:32:17 PDT
Created attachment 23455 [details]
Patch for this bug and bug 15384

I did try something simpler to address this bug alone (without bug 15384), which was basically for layoutBlockChildren() to always look at grandchildren of anonymous blocks and see if any of them had percentage heights. That code got hit quite frequently, so I think this might be a better solution.
Comment 12 Dave Hyatt 2008-09-15 22:44:10 PDT
Comment on attachment 23455 [details]
Patch for this bug and bug 15384

r=me, assuming you are confident it's not a performance regression.
Comment 13 mitz 2008-09-16 10:34:42 PDT
Fixed in <http://trac.webkit.org/changeset/36513>.