Bug 207122 – NetworkProcess should be notified by UIProcess when its service worker process connection should be on

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

NetworkProcess should be notified by UIProcess when its service worker process connection should be on

[youenn fablet]

<rdar://problem/59089780>

[youenn fablet]

Created attachment 389523 [details]
Patch

[youenn fablet]

Created attachment 389649 [details]
Patch

[youenn fablet]

Created attachment 389650 [details]
Patch

[youenn fablet]

<rdar://problem/58850406>

[WebKit Commit Bot]

Comment on attachment 389650 [details]
Patch

Clearing flags on attachment: 389650

Committed r255681: <https://trac.webkit.org/changeset/255681>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Comment on attachment 389650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389650&action=review

> Source/WebKit/UIProcess/WebProcessProxy.cpp:1610
> +    sendWithAsyncReply(Messages::WebProcess::EstablishWorkerContextConnectionToNetworkProcess { processPool().defaultPageGroup().pageGroupID(), m_serviceWorkerInformation->serviceWorkerPageProxyID, m_serviceWorkerInformation->serviceWorkerPageID, store, *m_registrableDomain, m_serviceWorkerInformation->initializationData }, [activity = m_throttler.backgroundActivity("Establish Service Worker"_s), completionHandler = WTFMove(completionHandler)]() mutable {

BTW, I think it is a great fix to take a background activity here. I had identified this as an issue locally and was about to upload a patch to fix this. Previously, the service worker process could suspend *before* having finished initialization and setup a connection to the network process. I am hoping this will address the flakiness issues on the bots.