Bug 20712 - Remove JSC_FAST_CALL if it is not a performance regression
Summary: Remove JSC_FAST_CALL if it is not a performance regression
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-07 22:32 PDT by Cameron Zwarich (cpst)
Modified: 2010-11-01 19:32 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (114.83 KB, text/plain)
2008-09-07 22:35 PDT, Cameron Zwarich (cpst) 		no flags Details
SunSpider results for last patch against r36264 (3.69 KB, text/plain)
2008-09-07 22:37 PDT, Cameron Zwarich (cpst) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-09-07 22:32:51 PDT 
Now that we only traverse the AST for bytecode generation and printing, the JSC_FAST_CALL intrinsic is likely unnecessary. We should remove it if it is not a performance regression.
Comment 1 Cameron Zwarich (cpst) 2008-09-07 22:35:49 PDT 
Created attachment 23239 [details]
Proposed patch
Comment 2 Cameron Zwarich (cpst) 2008-09-07 22:37:03 PDT 
Created attachment 23240 [details]
SunSpider results for last patch against r36264
Comment 3 Cameron Zwarich (cpst) 2008-09-07 22:44:19 PDT 
Comment on attachment 23239 [details]
Proposed patch

Oliver pointed out that I should test the V8 benchmark suite and non-JIT build configurations.
Comment 4 Xan Lopez 2010-11-01 19:32:08 PDT 
This happened in August 2009, so we can close the bug.