MediaDevices should handle changes of iframe allow attribute value

[youenn fablet]

MediaDevices should handle changes of iframe allow attribute value

[youenn fablet]

Created attachment 389499 [details]
Patch

[Eric Carlson]

Comment on attachment 389499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389499&action=review

> Source/WebCore/Modules/mediastream/MediaDevices.cpp:165
> +    bool canAccessCamera = isFeaturePolicyAllowedByDocumentAndAllOwners(FeaturePolicy::Type::Camera, *document, LogFeaturePolicyFailure::No);
> +    bool canAccessMicrophone = isFeaturePolicyAllowedByDocumentAndAllOwners(FeaturePolicy::Type::Microphone, *document, LogFeaturePolicyFailure::No);

It might be worth adding a helper function that calls both of these.

> Source/WebCore/Modules/mediastream/UserMediaController.cpp:68
> +        window->printErrorMessage(makeString("Not allowed to call getDisplayMedia."));

This isn't tested.

> Source/WebCore/html/FeaturePolicy.cpp:65
> +                document.domWindow()->printErrorMessage(makeString("Feature policy '", policyTypeName(type), "' check failed."));

Ditto.

[youenn fablet]

Created attachment 389511 [details]
Patch

[youenn fablet]

Created attachment 389636 [details]
Rebasing for landing

[WebKit Commit Bot]

Comment on attachment 389636 [details]
Rebasing for landing

Clearing flags on attachment: 389636

Committed r255668: <https://trac.webkit.org/changeset/255668>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59144287>