Update style checker with new locations OS version checks are allowed
Created attachment 389486 [details] Patch
I'd like to update the unit tests as well but I am not clear on how to run them. Anyone know how to run the unit tests in Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py?
Created attachment 389488 [details] Patch
For the time being, I will use my friendly EWS bot.
Created attachment 389489 [details] Patch
Locally, test-webkitpy will run this test among others.
(In reply to Alexey Proskuryakov from comment #6) > Locally, test-webkitpy will run this test among others. Cool. Is there a way to get it to just run the one I am interested in to iterate?
Comment on attachment 389489 [details] Patch Clearing flags on attachment: 389489 Committed r255553: <https://trac.webkit.org/changeset/255553>
All reviewed patches have been landed. Closing bug.
<rdar://problem/59100260>
> Cool. Is there a way to get it to just run the one I am interested in to > iterate? test-webkitpy webkitpy.style.checkers.cpp_unittest.WebKitStyleTest.test_os_version_checks
(In reply to Alexey Proskuryakov from comment #11) > > Cool. Is there a way to get it to just run the one I am interested in to > > iterate? > > test-webkitpy > webkitpy.style.checkers.cpp_unittest.WebKitStyleTest.test_os_version_checks Heh. Thanks. So many letters!
(In reply to Sam Weinig from comment #7) > (In reply to Alexey Proskuryakov from comment #6) > > Locally, test-webkitpy will run this test among others. > > Cool. Is there a way to get it to just run the one I am interested in to > iterate? Alexey's response here is correct, but it's worth noting that the tests are pretty quick (10-15 seconds) and we work pretty hard to keep them green. There are also integration tests, so it's not immediately obvious which tests will exercise new code.
> Heh. Thanks. So many letters! It's kind of like a test path, just dot separated :). Once it fails for the first time, you can copy/paste it from the result. CC Aakash Jain to consider whether we should preserve the leading "webkitpy.' everywhere in EWS - currently it is omitted, making it not straightforward to figure out how to run the subtest individually.
(In reply to Alexey Proskuryakov from comment #14) > > Heh. Thanks. So many letters! > > It's kind of like a test path, just dot separated :). Once it fails for the > first time, you can copy/paste it from the result. > > CC Aakash Jain to consider whether we should preserve the leading > "webkitpy.' everywhere in EWS - currently it is omitted, making it not > straightforward to figure out how to run the subtest individually. We definitely need to preserve webkitpy in EWS, there are a small subset of tests run by test-webkitpy that are NOT prefixed by webkitpy.
> CC Aakash Jain to consider whether we should preserve the leading > "webkitpy.' everywhere in EWS - currently it is omitted. I removed it for readability. I will add it back.
(In reply to Aakash Jain from comment #16) > I removed it for readability. I will add it back. Fixing in https://bugs.webkit.org/show_bug.cgi?id=207206