Bug 207099 - [LFC][Integration] Support intruding floats
Summary: [LFC][Integration] Support intruding floats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-02 05:14 PST by Antti Koivisto
Modified: 2020-02-09 17:52 PST (History)
5 users (show)

See Also:

Attachments
wip (7.39 KB, patch)
2020-02-02 06:54 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (9.47 KB, patch)
2020-02-09 15:56 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-02-02 05:14:24 PST 
SLL supports intruding floats, LFC integration should support them too.
Comment 1 Antti Koivisto 2020-02-02 06:54:24 PST 
Created attachment 389474 [details]
wip
Comment 2 Antti Koivisto 2020-02-09 15:56:20 PST 
Created attachment 390217 [details]
patch
Comment 3 zalan 2020-02-09 16:06:31 PST 
Comment on attachment 390217 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390217&action=review

> Source/WebCore/layout/floats/FloatingState.cpp:51
> +FloatingState::FloatItem::FloatItem(Position position, Display::Box absoluteDisplayBox)
> +    : m_position(position)
> +    , m_absoluteDisplayBox(absoluteDisplayBox)

At some point this needs to be expanded to cover isDescendantOfFormattingRoot() as well (with the current integration setup/content, we don't call it).
Comment 4 WebKit Commit Bot 2020-02-09 17:51:49 PST 
Comment on attachment 390217 [details]
patch

Clearing flags on attachment: 390217

Committed r256107: <https://trac.webkit.org/changeset/256107>
Comment 5 WebKit Commit Bot 2020-02-09 17:51:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-09 17:52:15 PST 
<rdar://problem/59298921>