RESOLVED FIXED 207099
[LFC][Integration] Support intruding floats 
https://bugs.webkit.org/show_bug.cgi?id=207099
Summary [LFC][Integration] Support intruding floats
Antti Koivisto
Reported 2020-02-02 05:14:24 PST
SLL supports intruding floats, LFC integration should support them too.
Attachments
wip (7.39 KB, patch)
2020-02-02 06:54 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (9.47 KB, patch)
2020-02-09 15:56 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-02-02 06:54:24 PST
Created attachment 389474 [details] wip
Antti Koivisto
Comment 2 2020-02-09 15:56:20 PST
Created attachment 390217 [details] patch
zalan
Comment 3 2020-02-09 16:06:31 PST
Comment on attachment 390217 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=390217&action=review > Source/WebCore/layout/floats/FloatingState.cpp:51 > +FloatingState::FloatItem::FloatItem(Position position, Display::Box absoluteDisplayBox) > + : m_position(position) > + , m_absoluteDisplayBox(absoluteDisplayBox) At some point this needs to be expanded to cover isDescendantOfFormattingRoot() as well (with the current integration setup/content, we don't call it).
WebKit Commit Bot
Comment 4 2020-02-09 17:51:49 PST
Comment on attachment 390217 [details] patch Clearing flags on attachment: 390217 Committed r256107: <https://trac.webkit.org/changeset/256107>
WebKit Commit Bot
Comment 5 2020-02-09 17:51:50 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-02-09 17:52:15 PST
<rdar://problem/59298921>
Note You need to log in before you can comment on or make changes to this bug.