Bug 207065 - Add support for specifying background colors when setting marked text
Summary: Add support for specifying background colors when setting marked text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-31 12:48 PST by Wenson Hsieh
Modified: 2020-01-31 16:46 PST (History)
19 users (show)

See Also:


Attachments
Patch (57.70 KB, patch)
2020-01-31 13:35 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Fix GTK build (58.24 KB, patch)
2020-01-31 13:45 PST, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch for EWS (58.17 KB, patch)
2020-01-31 14:56 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-01-31 12:48:57 PST
Allow clients to highlight ranges in marked text.
Comment 1 Wenson Hsieh 2020-01-31 12:49:14 PST
<rdar://problem/57876140>
Comment 2 Wenson Hsieh 2020-01-31 13:35:39 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2020-01-31 13:45:07 PST
Created attachment 389406 [details]
Fix GTK build
Comment 4 Tim Horton 2020-01-31 14:01:02 PST
Comment on attachment 389406 [details]
Fix GTK build

View in context: https://bugs.webkit.org/attachment.cgi?id=389406&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4535
> +        unsigned location = range.location;

why the local?
Comment 5 Wenson Hsieh 2020-01-31 14:01:47 PST
Comment on attachment 389406 [details]
Fix GTK build

View in context: https://bugs.webkit.org/attachment.cgi?id=389406&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4535
>> +        unsigned location = range.location;
> 
> why the local?

Whoops, no reason! Removed.
Comment 6 Wenson Hsieh 2020-01-31 14:56:25 PST
Created attachment 389421 [details]
Patch for EWS
Comment 7 WebKit Commit Bot 2020-01-31 16:44:15 PST
Comment on attachment 389421 [details]
Patch for EWS

Clearing flags on attachment: 389421

Committed r255532: <https://trac.webkit.org/changeset/255532>