Bug 207056 – [macOS] AirPlay sometimes stops after 60 minutes of playback

• Status: ASSIGNED
• Component: Media

[Eric Carlson]

AirPlay sometimes stops after 60 minutes of playback

<rdar://problem/53649508>

[Eric Carlson]

Created attachment 389381 [details]
Patch

[Jon Lee]

Comment on attachment 389381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389381&action=review

> Source/WebCore/ChangeLog:15
> +        AirPlay can't actually be active is an item doesn't have audio or video, so always claim

if* an item

> Source/WebCore/ChangeLog:16
> +        to have both during AirPlay.

any side effects if the video has no audio tracks?

[Eric Carlson]

Comment on attachment 389381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389381&action=review

>> Source/WebCore/ChangeLog:15
>> +        AirPlay can't actually be active is an item doesn't have audio or video, so always claim
> 
> if* an item

Oops!

>> Source/WebCore/ChangeLog:16
>> +        to have both during AirPlay.
> 
> any side effects if the video has no audio tracks?

No.

[Eric Carlson]

Created attachment 389407 [details]
Updated patch.

[Eric Carlson]

Created attachment 389519 [details]
Patch

[Eric Carlson]

Created attachment 389531 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 389531 [details]
Patch for landing.

Rejecting attachment 389531 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 389531, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13316107

[Eric Carlson]

Created attachment 389542 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 389542 [details]
Patch for landing.

Clearing flags on attachment: 389542

Committed r255581: <https://trac.webkit.org/changeset/255581>