Bug 207028 - [Cocoa] Remove NSURLSessionResumeInfoLocalPath workaround where not needed
Summary: [Cocoa] Remove NSURLSessionResumeInfoLocalPath workaround where not needed
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-30 19:26 PST by David Quesada
Modified: 2020-01-30 19:26 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Quesada 2020-01-30 19:26:42 PST 
CFNetwork fixed rdar://problem/34745171 in iOS 13 and macOS 10.15, which means that WebKit no longer needs the workaround of adding “NSURLSessionResumeInfoLocalPath” to resume data before creating a download task. However, the OS conditional in Download::resume() is set up so that non-Mac builds and 10.15-or-later Mac builds still attempt that workaround in the #else block. This workaround doesn’t have any effect (since CFNetwork changed the internal format of the resume data in macOS Mojave / iOS 12), and its presence only leaves the potential for a bug in the future if the format of the resume data blob is significantly changed in the future. We should remove this “workaround”. (keeping the first part of the #if/else around for Mojave)