[ews] We should set custom build summary for webkitpy tests, currently it says 'build successful' (e.g.: https://ews-build.webkit.org/#/builders/5/builds/17024), it should say 'Passed webkitpy tests' (or appropriate failure message). We had custom build summary prior to r254547, in which we removed self.build.buildFinished() which was being used to set custom build summary. Bug 207026 added another way to set custom build summary, so we should use that and set custom build summary for webkitpy tests.
Created attachment 389326 [details] Patch
Sample runs: https://ews-build.webkit-uat.org/#/builders/8/builds/102 https://ews-build.webkit-uat.org/#/builders/8/builds/103
'services' ews failure is because this patch is dependent on patch in Bug 207026.
(In reply to Aakash Jain from comment #3) > 'services' ews failure is because this patch is dependent on patch in Bug > 207026. Let's wait for https://bugs.webkit.org/show_bug.cgi?id=207026 to land so we can have green EWS before landing.
(In reply to Jonathan Bedard from comment #4) > Let's wait for https://bugs.webkit.org/show_bug.cgi?id=207026 to land so we can have green EWS before landing. Done. 'services' and 'style' bubbles are green now. win, ios-wk2 are flaky failures.
Comment on attachment 389326 [details] Patch Code looks good, but I'd like to see the example where Python 2 fails but Python 3 does not
> I'd like to see the example where Python 2 fails but Python 3 does not https://ews-build.webkit-uat.org/#/builders/8/builds/142
Comment on attachment 389326 [details] Patch Clearing flags on attachment: 389326 Committed r255580: <https://trac.webkit.org/changeset/255580>
All reviewed patches have been landed. Closing bug.
<rdar://problem/59118524>