RESOLVED FIXED 207027
[ews] Set custom build summary for webkitpy tests 
https://bugs.webkit.org/show_bug.cgi?id=207027
Summary [ews] Set custom build summary for webkitpy tests
Aakash Jain
Reported 2020-01-30 19:20:17 PST
[ews] We should set custom build summary for webkitpy tests, currently it says 'build successful' (e.g.: https://ews-build.webkit.org/#/builders/5/builds/17024), it should say 'Passed webkitpy tests' (or appropriate failure message). We had custom build summary prior to r254547, in which we removed self.build.buildFinished() which was being used to set custom build summary. Bug 207026 added another way to set custom build summary, so we should use that and set custom build summary for webkitpy tests.
Attachments
Patch (4.59 KB, patch)
2020-01-30 19:21 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-01-30 19:21:51 PST
Created attachment 389326 [details] Patch
Aakash Jain
Comment 3 2020-01-30 19:25:14 PST
'services' ews failure is because this patch is dependent on patch in Bug 207026.
Jonathan Bedard
Comment 4 2020-01-31 09:52:14 PST
(In reply to Aakash Jain from comment #3) > 'services' ews failure is because this patch is dependent on patch in Bug > 207026. Let's wait for https://bugs.webkit.org/show_bug.cgi?id=207026 to land so we can have green EWS before landing.
Aakash Jain
Comment 5 2020-01-31 10:11:21 PST
(In reply to Jonathan Bedard from comment #4) > Let's wait for https://bugs.webkit.org/show_bug.cgi?id=207026 to land so we can have green EWS before landing. Done. 'services' and 'style' bubbles are green now. win, ios-wk2 are flaky failures.
Jonathan Bedard
Comment 6 2020-01-31 10:18:39 PST
Comment on attachment 389326 [details] Patch Code looks good, but I'd like to see the example where Python 2 fails but Python 3 does not
Aakash Jain
Comment 7 2020-02-03 10:58:33 PST
> I'd like to see the example where Python 2 fails but Python 3 does not https://ews-build.webkit-uat.org/#/builders/8/builds/142
WebKit Commit Bot
Comment 8 2020-02-03 11:41:46 PST
Comment on attachment 389326 [details] Patch Clearing flags on attachment: 389326 Committed r255580: <https://trac.webkit.org/changeset/255580>
WebKit Commit Bot
Comment 9 2020-02-03 11:41:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2020-02-03 11:42:15 PST
<rdar://problem/59118524>
Note You need to log in before you can comment on or make changes to this bug.