Bug 207016 - [GTK] http/tests/misc/form-submit-file-cross-site-redirect.html fails with incomplete form data
Summary: [GTK] http/tests/misc/form-submit-file-cross-site-redirect.html fails with in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-30 13:55 PST by Lauro Moura
Modified: 2020-02-14 13:28 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2020-02-14 12:29 PST, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-01-30 13:55:57 PST
With b206517 fixed, this test submits the test file metadata correctly (like the non-redirect version) but no payload is sent.


--- /home/lauro/dev/WebKit/layout-test-results/http/tests/misc/form-submit-file-cross-site-redirect-expected.txt
+++ /home/lauro/dev/WebKit/layout-test-results/http/tests/misc/form-submit-file-cross-site-redirect-actual.txt
@@ -2,6 +2,6 @@
 This tests verifies the test file included in the multipart form data:
 
 PASS: File is present
 PASS: File upload was successful
-PASS: File size is greater than 0
+FAIL: File size is 0
 


Payload with `var_dump($_FILES['data']);` in the PHP script:

```
array(5) {
  ["name"]=>
  string(8) "test.tmp"
 ["type"]=>
  string(24) "application/octet-stream"
  ["tmp_name"]=>
  string(14) "/tmp/php0dQ3qM"
  ["error"]=>
  int(0)
  ["size"]=>
  int(0)
}
```

Using the original test from Julio in b201950[1] with Minibrowser it seems to work normally.

[1] https://redirection-experiment.herokuapp.com/
Comment 1 Carlos Alberto Lopez Perez 2020-02-03 09:10:30 PST
(In reply to Lauro Moura from comment #0)
> With b206517 fixed
tips:
- instead of " b206517 " use format: " bug 206517 " so bugzilla makes automatic links
- if the bug its related to GTK or WPE releated, always CC the virtual user bugs-noreply@webkitgtk.org
Comment 2 Lauro Moura 2020-02-14 12:29:51 PST
Created attachment 390796 [details]
Patch
Comment 3 WebKit Commit Bot 2020-02-14 13:26:57 PST
The commit-queue encountered the following flaky tests while processing attachment 390796 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-02-14 13:27:38 PST
Comment on attachment 390796 [details]
Patch

Clearing flags on attachment: 390796

Committed r256638: <https://trac.webkit.org/changeset/256638>
Comment 5 WebKit Commit Bot 2020-02-14 13:27:39 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-14 13:28:16 PST
<rdar://problem/59469874>