Bug 207005 - [CMake] Add SQLite::SQLite3 target
Summary: [CMake] Add SQLite::SQLite3 target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-30 09:54 PST by Ross Kirsling
Modified: 2020-01-30 16:53 PST (History)
8 users (show)

See Also:

Attachments
Patch (12.49 KB, patch)
2020-01-30 09:57 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (13.37 KB, patch)
2020-01-30 11:44 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (13.36 KB, patch)
2020-01-30 14:02 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2020-01-30 09:54:17 PST 
[CMake] Add SQLite::SQLite3 target
Comment 1 Ross Kirsling 2020-01-30 09:57:36 PST 
Created attachment 389260 [details]
Patch
Comment 2 Don Olmstead 2020-01-30 10:00:03 PST 
Comment on attachment 389260 [details]
Patch

r=me

Just wait for the bots.
Comment 3 Ross Kirsling 2020-01-30 11:44:58 PST 
Created attachment 389273 [details]
Patch
Comment 4 Don Olmstead 2020-01-30 13:55:33 PST 
Comment on attachment 389273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389273&action=review

> Source/cmake/OptionsAppleWin.cmake:13
> +find_package(SQLite3 3.23.1 REQUIRED)

Just make it REQUIRED without the version like OptionsGTK does. The one AppleWin is using is ancient.
Comment 5 Ross Kirsling 2020-01-30 14:02:52 PST 
Created attachment 389285 [details]
Patch
Comment 6 WebKit Commit Bot 2020-01-30 16:52:04 PST 
Comment on attachment 389285 [details]
Patch

Clearing flags on attachment: 389285

Committed r255475: <https://trac.webkit.org/changeset/255475>
Comment 7 WebKit Commit Bot 2020-01-30 16:52:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-01-30 16:53:16 PST 
<rdar://problem/59047569>