Bug 206992 - Regression: http/tests/loading/remove-child-triggers-parser.html is failing consistently on windows
Summary: Regression: http/tests/loading/remove-child-triggers-parser.html is failing c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-30 04:34 PST by Aakash Jain
Modified: 2020-03-03 21:17 PST (History)
9 users (show)

See Also:


Attachments
Fixes the test (2.00 KB, patch)
2020-01-30 18:19 PST, Ryosuke Niwa
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Aakash Jain 2020-01-30 04:35:07 PST
Diff:

--- /home/buildbot/worker/Windows-EWS/build/layout-test-results/http/tests/loading/remove-child-triggers-parser-expected.txt
+++ /home/buildbot/worker/Windows-EWS/build/layout-test-results/http/tests/loading/remove-child-triggers-parser-actual.txt
@@ -3,3 +3,4 @@
 main frame - didFinishDocumentLoadForFrame
 main frame - didHandleOnloadEventsForFrame
 main frame - didFinishLoadForFrame
+ERROR: nil result from IDOMElement::innerText
Comment 2 Aakash Jain 2020-01-30 04:37:32 PST
Possible regression point: r255223 (Bug 103115:http/tests/loading/remove-child-triggers-parser.html is flaky)
Comment 3 Radar WebKit Bug Importer 2020-01-30 04:37:55 PST
<rdar://problem/59025071>
Comment 4 Ryosuke Niwa 2020-01-30 14:47:49 PST
Huh, I guess IDOMElement::innerText doesn't like the fact there is no document element anymore. I guess we'd work around that in the test itself.
Comment 5 Ryosuke Niwa 2020-01-30 18:19:58 PST
Created attachment 389324 [details]
Fixes the test
Comment 6 Ryosuke Niwa 2020-01-30 18:27:06 PST
Committed r255481: <https://trac.webkit.org/changeset/255481>
Comment 7 Ryosuke Niwa 2020-03-03 21:17:45 PST
This test appears to be passing now.