Bug 206970 – Don't include VM.h in CallFrame.h

• Status: NEW
• Component: JavaScriptCore

[Robin Morisset]

CallFrame.h is pretty small, and is included in lots of places. It currently includes VM.h which is huge and brings in a ton of code, all just for DECLARE_CALL_FRAME, which takes vm as argument.
This macro could as easily be declared in VM.h, and it significantly help compile times for all the files which don't use it (and so no longer have to depend on VM.h)

[Robin Morisset]

Created attachment 389192 [details]
Patch

[Saam Barati]

Comment on attachment 389192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389192&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        This macro could as easily be declared in VM.h, and it significantly help compile times for all the files which don't use it (and so no longer have to depend on VM.h)

"help" => "helps"

[Mark Lam]

Comment on attachment 389192 [details]
Patch

Can you add a comment next to the DECLARE_CALL_FRAME macro indicating that it was moved here from CallFrame.h so that CallFrame.h doesn’t have to include VM.h, and that this is needed to reduce build time.

[Robin Morisset]

Created attachment 389614 [details]
Patch

Add a comment per Mark's suggestion, and add a missing '#include "CPU.h"' which was causing failures in the 32-bit x86 EWS bot.

[Robin Morisset]

Created attachment 389857 [details]
Patch

rebase

[Robin Morisset]

Created attachment 389885 [details]
Patch