Bug 206966 – Don't include CCallHelpers.h in B3Procedure.h

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Robin Morisset]

It brings in AssemblyHelpers.h, which includes CodeBlock.h which brings basically the entire runtime.
There is no need for random B3 files to know about Heap.h or Structure.h or anything like that.

[Robin Morisset]

Created attachment 389185 [details]
Patch

[Robin Morisset]

Created attachment 389186 [details]
fix style nit

[Saam Barati]

Comment on attachment 389186 [details]
fix style nit

View in context: https://bugs.webkit.org/attachment.cgi?id=389186&action=review

> Source/JavaScriptCore/b3/testb3_6.cpp:2176
> +    CodeLocationLabel<B3CompilationPtrTag> labelOne = linkBuffer.locationOf<B3CompilationPtrTag>(proc.code().entrypointLabel(0));

should we also make AirCode not use Label directly?

[Saam Barati]

(In reply to Saam Barati from comment #3)
> Comment on attachment 389186 [details]
> fix style nit
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389186&action=review
> 
> > Source/JavaScriptCore/b3/testb3_6.cpp:2176
> > +    CodeLocationLabel<B3CompilationPtrTag> labelOne = linkBuffer.locationOf<B3CompilationPtrTag>(proc.code().entrypointLabel(0));
> 
> should we also make AirCode not use Label directly?

We could also make Label not depend on AssemblerLabel/Masm since we only have one type per compilation target

[WebKit Commit Bot]

Comment on attachment 389186 [details]
fix style nit

Clearing flags on attachment: 389186

Committed r255394: <https://trac.webkit.org/changeset/255394>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59009948>